linux-kernel - Re: [PATCH] dt-bindings: pps: gpio: Correct indentation and style in DTS example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8bd8ca96-1334-42c7-8dc4-2db1785301b9@enneenne.com>
Date: Mon, 24 Mar 2025 14:15:39 +0100
From: Rodolfo Giometti <giometti@...eenne.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Fabio Estevam <festevam@...il.com>,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: pps: gpio: Correct indentation and style in
 DTS example

On 24/03/25 13:51, Krzysztof Kozlowski wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
> 
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Acked-by: Rodolfo Giometti <giometti@...eenne.com>

> ---
>   .../devicetree/bindings/pps/pps-gpio.yaml     | 20 +++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pps/pps-gpio.yaml b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> index fd4adfa8d2d4..383a838744eb 100644
> --- a/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> +++ b/Documentation/devicetree/bindings/pps/pps-gpio.yaml
> @@ -36,14 +36,14 @@ additionalProperties: false
>   
>   examples:
>     - |
> -      #include <dt-bindings/gpio/gpio.h>
> +    #include <dt-bindings/gpio/gpio.h>
>   
> -      pps {
> -          compatible = "pps-gpio";
> -          pinctrl-names = "default";
> -          pinctrl-0 = <&pinctrl_pps>;
> -          gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> -          assert-falling-edge;
> -          echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
> -          echo-active-ms = <100>;
> -      };
> +    pps {
> +        compatible = "pps-gpio";
> +        pinctrl-names = "default";
> +        pinctrl-0 = <&pinctrl_pps>;
> +        gpios = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> +        assert-falling-edge;
> +        echo-gpios = <&gpio1 27 GPIO_ACTIVE_HIGH>;
> +        echo-active-ms = <100>;
> +    };

-- 
GNU/Linux Solutions                  e-mail: giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming