linux-kernel - Re: [PATCH 2/2] dt-bindings: mfd: Correct indentation and style in DTS example

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdXkePsSX62+OyT8aTdqFfaNy9dGRM73Q5AuQ_pHTBi8Kg@mail.gmail.com>
Date: Mon, 24 Mar 2025 14:31:46 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Lee Jones <lee@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Colin Foster <colin.foster@...advantage.com>, 
	Jonathan Neuschäfer <j.neuschaefer@....net>, 
	Marek Vasut <marek.vasut+renesas@...il.com>, Chen-Yu Tsai <wens@...e.org>, 
	Jeff LaBundy <jeff@...undy.com>, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH 2/2] dt-bindings: mfd: Correct indentation and style in
 DTS example

Hi Krzysztof,

On Mon, 24 Mar 2025 at 13:55, Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.  While re-indenting, drop
> unused labels.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> +++ b/Documentation/devicetree/bindings/mfd/iqs62x.yaml
> @@ -60,43 +60,34 @@ examples:
>      #include <dt-bindings/interrupt-controller/irq.h>
>
>      i2c {
> -            #address-cells = <1>;
> -            #size-cells = <0>;
> +        #address-cells = <1>;
> +        #size-cells = <0>;
>
> -            iqs620a@44 {
> -                    compatible = "azoteq,iqs620a";
> -                    reg = <0x44>;
> -                    interrupt-parent = <&gpio>;
> -                    interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
> +        iqs620a@44 {
> +            compatible = "azoteq,iqs620a";
> +            reg = <0x44>;
> +            interrupt-parent = <&gpio>;
> +            interrupts = <17 IRQ_TYPE_LEVEL_LOW>;
>
> -                    keys {
> -                            compatible = "azoteq,iqs620a-keys";
> +            keys {
> +                compatible = "azoteq,iqs620a-keys";
>
> -                            linux,keycodes = <KEY_SELECT>,
> -                                             <KEY_MENU>,
> -                                             <KEY_OK>,
> -                                             <KEY_MENU>;
> +                linux,keycodes = <KEY_SELECT>,
> +                                 <KEY_MENU>,
> +                                 <KEY_OK>,
> +                                 <KEY_MENU>;
>
> -                            hall-switch-south {
> -                                    linux,code = <SW_LID>;
> -                                    azoteq,use-prox;
> -                            };
> -                    };
> -
> -                    iqs620a_pwm: pwm {
> -                            compatible = "azoteq,iqs620a-pwm";
> -                            #pwm-cells = <2>;
> -                    };
> +                hall-switch-south {
> +                    linux,code = <SW_LID>;
> +                    azoteq,use-prox;
> +                };
>              };
> -    };
>
> -    pwmleds {
> -            compatible = "pwm-leds";
> -
> -            led-1 {
> -                    pwms = <&iqs620a_pwm 0 1000000>;
> -                    max-brightness = <255>;
> +            iqs620a_pwm: pwm {
> +                compatible = "azoteq,iqs620a-pwm";
> +                #pwm-cells = <2>;
>              };
> +        };
>      };
>
>    - |

The removal of the pwmleds node belongs in patch [1/2].
The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds