linux-kernel - Re: [PATCH v2 53/59] drm-dyndbg: add DRM_CLASSMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <783e4ea5-9adb-450e-b292-c52292714ded@bootlin.com>
Date: Mon, 24 Mar 2025 16:00:26 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: Jim Cromie <jim.cromie@...il.com>, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
 intel-gvt-dev@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org,
 intel-gfx-trybot@...ts.freedesktop.org
Cc: jbaron@...mai.com, gregkh@...uxfoundation.org, ukaszb@...omium.org,
 daniel.vetter@...ll.ch, tvrtko.ursulin@...ux.intel.com,
 jani.nikula@...el.com, ville.syrjala@...ux.intel.com
Subject: Re: [PATCH v2 53/59] drm-dyndbg: add DRM_CLASSMAP_USE to udl driver



Le 20/03/2025 à 19:52, Jim Cromie a écrit :
> The udl driver has a number of DRM_UT_* debugs, make them
> controllable when CONFIG_DRM_USE_DYNAMIC_DEBUG=y by telling dyndbg
> that the module uses them.
> 
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> ---
>   drivers/gpu/drm/udl/udl_main.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/udl/udl_main.c b/drivers/gpu/drm/udl/udl_main.c
> index 3ebe2ce55dfd..ba57c14454e5 100644
> --- a/drivers/gpu/drm/udl/udl_main.c
> +++ b/drivers/gpu/drm/udl/udl_main.c
> @@ -19,6 +19,8 @@
>   
>   #define NR_USB_REQUEST_CHANNEL 0x12
>   
> +DRM_CLASSMAP_USE(drm_debug_classes);

ditto, is it better to put it near the module entry point [1]?

[1]:https://elixir.bootlin.com/linux/v6.13.7/source/drivers/gpu/drm/udl/udl_drv.c

> +
>   #define MAX_TRANSFER (PAGE_SIZE*16 - BULK_SIZE)
>   #define WRITES_IN_FLIGHT (20)
>   #define MAX_VENDOR_DESCRIPTOR_SIZE 256

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com