linux-kernel - Re: [PATCH v2 44/59] drm-dyndbg: add DRM_CLASSMAP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c3514758-5a22-4acb-8ff0-1f4ddade02f4@bootlin.com>
Date: Mon, 24 Mar 2025 16:24:15 +0100
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: Jim Cromie <jim.cromie@...il.com>, linux-kernel@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, amd-gfx@...ts.freedesktop.org,
 intel-gvt-dev@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org,
 intel-gfx-trybot@...ts.freedesktop.org
Cc: jbaron@...mai.com, gregkh@...uxfoundation.org, ukaszb@...omium.org,
 daniel.vetter@...ll.ch, tvrtko.ursulin@...ux.intel.com,
 jani.nikula@...el.com, ville.syrjala@...ux.intel.com
Subject: Re: [PATCH v2 44/59] drm-dyndbg: add DRM_CLASSMAP_USE to Xe driver



Le 20/03/2025 à 19:52, Jim Cromie a écrit :
> Invoke DRM_CLASSMAP_USE from xe_drm_client.c.  When built with
> CONFIG_DRM_USE_DYNAMIC_DEBUG=y, this tells dydnbg that Xe uses
> has drm.debug calls.
> 
> Signed-off-by: Jim Cromie <jim.cromie@...il.com>
> ---
>   drivers/gpu/drm/xe/xe_drm_client.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/xe/xe_drm_client.c b/drivers/gpu/drm/xe/xe_drm_client.c
> index 2d4874d2b922..756dba5c88f8 100644
> --- a/drivers/gpu/drm/xe/xe_drm_client.c
> +++ b/drivers/gpu/drm/xe/xe_drm_client.c
> @@ -21,6 +21,8 @@
>   #include "xe_pm.h"
>   #include "xe_trace.h"
>   
> +DRM_CLASSMAP_USE(drm_debug_classes);
> +

Is xe_drm_client.c the best place to do it? I think the module entry 
point is a bit better [1].

[1]:https://elixir.bootlin.com/linux/v6.13.7/source/drivers/gpu/drm/xe/xe_module.c

>   /**
>    * DOC: DRM Client usage stats
>    *

-- 
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com