linux-kernel - Re: [PATCH v6 07/11] misc: amd-sbi: Add support for mailbox error codes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d05242e6-4706-4abd-973f-230d143137e8@app.fastmail.com>
Date: Mon, 24 Mar 2025 16:26:40 +0100
From: "Arnd Bergmann" <arnd@...db.de>
To: "Akshay Gupta" <akshay.gupta@....com>, linux-hwmon@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: "Guenter Roeck" <linux@...ck-us.net>,
 "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>, shyam-sundar.s-k@....com,
 gautham.shenoy@....com, "Mario Limonciello" <mario.limonciello@....com>,
 naveenkrishna.chatradhi@....com, anand.umarji@....com
Subject: Re: [PATCH v6 07/11] misc: amd-sbi: Add support for mailbox error codes

On Mon, Mar 24, 2025, at 15:58, Akshay Gupta wrote:
> APML mailbox protocol returns additional error codes written by
> SMU firmware in the out-bound register 0x37. These errors include,
> invalid core, message not supported over platform and
> others. This additional error codes can be used to provide more
> details to user space.
>
> Reviewed-by: Naveen Krishna Chatradhi <naveenkrishna.chatradhi@....com>
> Signed-off-by: Akshay Gupta <akshay.gupta@....com>

This is an incompatible change to the uapi definition, which you
should never do. Just merge it into the previous patch that
adds the api in the first place.

      Arnd