linux-kernel - Re: [PATCH v1 3/6] tracing: Mark binary printing functions with _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250324120242.49253139@gandalf.local.home>
Date: Mon, 24 Mar 2025 12:02:42 -0400
From: Steven Rostedt <rostedt@...dmis.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Petr Mladek <pmladek@...e.com>, Christophe JAILLET
 <christophe.jaillet@...adoo.fr>, Kees Cook <kees@...nel.org>, "Masami
 Hiramatsu (Google)" <mhiramat@...nel.org>, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org, linux-trace-kernel@...r.kernel.org, John
 Ogness <john.ogness@...utronix.de>, Sergey Senozhatsky
 <senozhatsky@...omium.org>, Andy Shevchenko <andy@...nel.org>, Mathieu
 Desnoyers <mathieu.desnoyers@...icios.com>, Andrew Morton
 <akpm@...ux-foundation.org>, Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH v1 3/6] tracing: Mark binary printing functions with
 __printf() attribute

On Thu, 20 Mar 2025 20:04:24 +0200
Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:

> @@ -113,7 +113,8 @@ static inline __printf(2, 3)
>  void trace_seq_printf(struct trace_seq *s, const char *fmt, ...)
>  {
>  }
> -static inline void
> +static inline __printf(2, 0)
> +void
>  trace_seq_bprintf(struct trace_seq *s, const char *fmt, const u32 *binary)
>  {
>  }

Do we need to split the line after the __printf()? Can't the above be:

static inline __printf(2, 0) void
trace_seq_bprintf(struct trace_seq *s, const char *fmt, const u32 *binary)

Or even:

__printf(2, 0)
static inline void
trace_seq_bprintf(struct trace_seq *s, const char *fmt, const u32 *binary)

I rather not split the prefix elements of a function over two lines. I
rather not even split them from the function itself, but tend to do that if
space is needed.

-- Steve