linux-kernel - Re: [PATCH v2 1/1] PCI/hotplug: Don't enable HPIE in poll mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250324164126.GA1252202@bhelgaas>
Date: Mon, 24 Mar 2025 11:41:26 -0500
From: Bjorn Helgaas <helgaas@...nel.org>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: Lukas Wunner <lukas@...ner.de>, Bjorn Helgaas <bhelgaas@...gle.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
	Mika Westerberg <mika.westerberg@...ux.intel.com>,
	linux-pci@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 1/1] PCI/hotplug: Don't enable HPIE in poll mode

On Mon, Mar 24, 2025 at 01:00:33PM +0200, Ilpo Järvinen wrote:
> On Fri, 21 Mar 2025, Bjorn Helgaas wrote:
> 
> > On Fri, Mar 21, 2025 at 07:07:47PM +0100, Lukas Wunner wrote:
> > > On Fri, Mar 21, 2025 at 12:09:19PM -0500, Bjorn Helgaas wrote:
> > > ...

> > > >   - It's annoying that pcie_enable_interrupt() and
> > > >     pcie_disable_interrupt() are global symbols, a consequence of
> > > >     pciehp being split across five files instead of being one, which
> > > >     is also a nuisance for code browsing.
> ...

> > > The only reason I've refrained from making major adjustments to this
> > > structure in the past was that it would make "git blame" a little more
> > > difficult and applying fixes to stable kernels would also become somewhat
> > > more painful as it would require backporting.
> > 
> > Yeah, that's the main reason I haven't tried to do anything either.
> > On the other hand, the browsing nuisance is an everyday thing forever
> > if we leave it as-is.
> 
> I get half mad every time I need to browse code under hotplug/. I even 
> started doing:
> 
>   cat ./pciehp*.[hc] | less -S 
> 
> ...to workaround the constant need to jump between those files. I 
> certainly would like to see the split gone especially between ctrl and 
> hpc.

I would definitely take patches to consolidate pciehp and maybe
acpiphp.

The other drivers are annoying, too, but I'm not sure it's worth the
trouble since they're rarely used and updated.

> Can't git blame be given -M -C to deal with this? Or are those truly lines 
> that were introduced by the consolidation commit?

I'm so git-illiterate that I habitually just search "git log -p".  
"git blame -M -C ..." would probably be much more effective.

Bjorn