linux-kernel - Re: [PATCH v1] arm64: dts: qcom: sa8775p: Add default pin configurations for QUP SEs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f565fee7-b222-4e6b-b022-68aed9a7d9ea@quicinc.com>
Date: Mon, 24 Mar 2025 22:14:03 +0530
From: Viken Dadhaniya <quic_vdadhani@...cinc.com>
To: Bjorn Andersson <andersson@...nel.org>
CC: <konradybcio@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <quic_msavaliy@...cinc.com>, <quic_anupkulk@...cinc.com>
Subject: Re: [PATCH v1] arm64: dts: qcom: sa8775p: Add default pin
 configurations for QUP SEs



On 3/4/2025 10:05 AM, Bjorn Andersson wrote:
> On Tue, Feb 25, 2025 at 09:11:36PM +0530, Viken Dadhaniya wrote:
>> Default pinctrl configurations for all QUP (Qualcomm Universal Peripheral)
>> Serial Engines (SEs) are missing in the SoC device tree. These
>> configurations are required by client teams when enabling any SEs as I2C,
>> SPI, or Serial protocols.
>>
>> Add default pin configurations for Serial Engines (SEs) for all supported
>> protocols, including I2C, SPI, and UART, to the sa8775p device tree.  This
>> change facilitates slave device driver clients to enable usecase with
>> minimal modifications.
>>
>> Additionally, move default pin configurations from target-specific files to
>> the SoC device tree file, as all possible pin configurations are now
>> comprehensively included in the SoC device tree, similar to other SoCs.
>>
>> Signed-off-by: Viken Dadhaniya <quic_vdadhani@...cinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sa8775p-ride.dtsi |  88 --
>>   arch/arm64/boot/dts/qcom/sa8775p.dtsi      | 908 +++++++++++++++++++++
>>   2 files changed, 908 insertions(+), 88 deletions(-)
>>
> [..]
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi
> [..]
>> +			qup_i2c0_default: qup-i2c0-state {
>> +				pins = "gpio20", "gpio21";
>> +				function = "qup0_se0";
>> +				drive-strength = <2>;
>> +				bias-pull-up;
> 
> Look at other examples, such as sc7280.dtsi, and you will see that
> drive-strength and bias are considered board-specific properties and
> should thereby not go in the soc.dtsi file.
> 

Removed drive-strength and bias in v2.

> Thanks,
> Bjorn