linux-kernel - Re: [PATCH net v1 1/1] net: dsa: microchip: fix DCB apptrust configuration on KSZ88x3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250325153455.GV892515@horms.kernel.org>
Date: Tue, 25 Mar 2025 15:34:55 +0000
From: Simon Horman <horms@...nel.org>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>, Andrew Lunn <andrew@...n.ch>,
	Eric Dumazet <edumazet@...gle.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Vladimir Oltean <olteanv@...il.com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	Arun Ramadoss <arun.ramadoss@...rochip.com>, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	UNGLinuxDriver@...rochip.com,
	Søren Andersen <san@...v.dk>
Subject: Re: [PATCH net v1 1/1] net: dsa: microchip: fix DCB apptrust
 configuration on KSZ88x3

On Fri, Mar 21, 2025 at 03:10:44PM +0100, Oleksij Rempel wrote:
> Remove KSZ88x3-specific priority and apptrust configuration logic that was
> based on incorrect register access assumptions. Also fix the register
> offset for KSZ8_REG_PORT_1_CTRL_0 to align with get_port_addr() logic.
> 
> The KSZ88x3 switch family uses a different register layout compared to
> KSZ9477-compatible variants. Specifically, port control registers need
> offset adjustment through get_port_addr(), and do not match the datasheet
> values directly.
> 
> Commit a1ea57710c9d ("net: dsa: microchip: dcb: add special handling for
> KSZ88X3 family") introduced quirks based on datasheet offsets, which do
> not work with the driver's internal addressing model. As a result, these
> quirks addressed the wrong ports and caused unstable behavior.
> 
> This patch removes all KSZ88x3-specific DCB quirks and corrects the port
> control register offset, effectively restoring working and predictable
> apptrust configuration.
> 
> Fixes: a1ea57710c9d ("net: dsa: microchip: dcb: add special handling for KSZ88X3 family")
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>

Reviewed-by: Simon Horman <horms@...nel.org>