linux-kernel - Re: [linux-next-20250324]/tool/bpf/bpftool fails to complie on linux-next-20250324

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAP4=nvTUcMfXgfLNai2OQmnEiy5wv9OHGZyA1agdA+pUi2cHYw@mail.gmail.com>
Date: Tue, 25 Mar 2025 16:45:16 +0100
From: Tomas Glozar <tglozar@...hat.com>
To: Quentin Monnet <qmo@...nel.org>
Cc: Saket Kumar Bhaskar <skb99@...ux.ibm.com>, Venkat Rao Bagalkote <venkat88@...ux.ibm.com>, 
	Hari Bathini <hbathini@...ux.ibm.com>, bpf <bpf@...r.kernel.org>, 
	LKML <linux-kernel@...r.kernel.org>, linuxppc-dev@...ts.ozlabs.org, 
	jkacur@...hat.com, lgoncalv@...hat.com, gmonaco@...hat.com, 
	williams@...hat.com, rostedt@...dmis.org
Subject: Re: [linux-next-20250324]/tool/bpf/bpftool fails to complie on linux-next-20250324

út 25. 3. 2025 v 16:27 odesílatel Quentin Monnet <qmo@...nel.org> napsal:
> Sorry I don't understand the issue, why not simply rename the variable
> that you introduced in tools/build/feature/Makefile at the same time, as
> well? That should solve it, no? This way you don't have to export it
> from the rtla Makefiles. Or am I missing something?
>

If I set BPFTOOL in the rtla makefiles, then it won't propagate to the
feature check, unless exported. I observed feature testing of clang
works, because CLANG is set in tools/scripts/Makefile.include, and did
the same thing for BPFTOOL.

> I think this was the intent.

I see.

> The variable name needs to change either for rtla + probe, or for all
> BPF utilities relying on it, indeed. As far as I can see, this is the
> sched_ext and runqslower utilities as well as the selftests for bpf,
> sched_ext, and hid. I'd argue that the variable has been in use in the
> Makefiles for these tools and selftests for a while, and renaming it
> might produce errors for anyone already using it to pass a specfic
> version of bpftool to try.

That sounds much better than renaming the existing BPFTOOL variable,
thanks for the suggestion. I will send a patch tomorrow and give you a
Suggested-by.

> Note: Not that many dependencies, most of them are optional. For
> bootstrap bpftool we pass -lelf, -lz, sometimes -lzstd.

Noted. I must have been thinking of the entire long list of
dependencies in tools/perf/Makefile.config, completely unrelated to
this. Sorry for the confusion.

Tomas