linux-kernel - Re: [PATCH] platform: cznic: fix function parameter names

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250325155906.GA1886499@ax162>
Date: Tue, 25 Mar 2025 08:59:06 -0700
From: Nathan Chancellor <nathan@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Marek Behún <kabel@...nel.org>,
	Arnd Bergmann <arnd@...db.de>, kernel test robot <lkp@...el.com>,
	Nick Desaulniers <ndesaulniers@...gle.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>, linux-kernel@...r.kernel.org,
	llvm@...ts.linux.dev
Subject: Re: [PATCH] platform: cznic: fix function parameter names

On Fri, Mar 21, 2025 at 09:53:07AM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> A invalid prototype made it into a previous patch, causing an clang warning:
> 
> drivers/platform/cznic/turris-signing-key.c:25:55: warning: omitting the parameter name in a function definition is a C23 extension [-Wc23-extensions]
> 
> and a slightly different warning with gcc-11 and earlier but not gcc-12 and up:
> 
> drivers/platform/cznic/turris-signing-key.c: In function 'turris_signing_key_instantiate':
> drivers/platform/cznic/turris-signing-key.c:25:43: error: parameter name omitted
> 
> Add the parameters to get a clean build with all compilers.
> 
> Fixes: 0b28b7080ef5 ("platform: cznic: Add keyctl helpers for Turris platform")
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202503210450.AoOpbJXC-lkp@intel.com/
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Nathan Chancellor <nathan@...nel.org>

You will be taking this I assume?

> ---
>  drivers/platform/cznic/turris-signing-key.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/cznic/turris-signing-key.c b/drivers/platform/cznic/turris-signing-key.c
> index 3b12e5245fb7..3827178565e2 100644
> --- a/drivers/platform/cznic/turris-signing-key.c
> +++ b/drivers/platform/cznic/turris-signing-key.c
> @@ -22,7 +22,8 @@
>  
>  #include <linux/turris-signing-key.h>
>  
> -static int turris_signing_key_instantiate(struct key *, struct key_preparsed_payload *)
> +static int turris_signing_key_instantiate(struct key *key,
> +					  struct key_preparsed_payload *payload)
>  {
>  	return 0;
>  }
> -- 
> 2.39.5
>