linux-kernel - Re: [PATCH net] net: mana: Switch to page pool for jumbo frames

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250325091335.6833ed27@kernel.org>
Date: Tue, 25 Mar 2025 09:13:35 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: linux-hyperv@...r.kernel.org, netdev@...r.kernel.org,
 decui@...rosoft.com, stephen@...workplumber.org, kys@...rosoft.com,
 paulros@...rosoft.com, olaf@...fle.de, vkuznets@...hat.com,
 davem@...emloft.net, wei.liu@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, leon@...nel.org, longli@...rosoft.com,
 ssengar@...ux.microsoft.com, linux-rdma@...r.kernel.org,
 daniel@...earbox.net, john.fastabend@...il.com, bpf@...r.kernel.org,
 ast@...nel.org, hawk@...nel.org, tglx@...utronix.de,
 shradhagupta@...ux.microsoft.com, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH net] net: mana: Switch to page pool for jumbo frames

On Fri, 21 Mar 2025 18:04:35 -0700 Haiyang Zhang wrote:
> Since commit 8218f62c9c9b ("mm: page_frag: use initial zero offset for
> page_frag_alloc_align()"), the netdev_alloc_frag() no longer works for
> fragsz > PAGE_SIZE. And, this behavior is by design.

This is inaccurate, AFAIU. The user of frag allocator with fragsz >
PAGE_SIZE has _always_ been incorrect. It's just that it fails in
a more obvious way now? Please correct the commit message.
-- 
pw-bot: cr