linux-kernel - Re: [PATCH net-next] netpoll: optimize struct layout for cache efficiency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250325100017.257cb04b@kernel.org>
Date: Tue, 25 Mar 2025 10:00:17 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Breno Leitao <leitao@...ian.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Simon Horman
 <horms@...nel.org>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 kernel-team@...a.com
Subject: Re: [PATCH net-next] netpoll: optimize struct layout for cache
 efficiency

On Tue, 25 Mar 2025 09:50:21 -0700 Breno Leitao wrote:
> > It's a little odd to leave the tracker in hot data, if you do it
> > should at least be adjacent to the pointer it tracks?  
> 
> Double-checking this better, netdevice_tracker is NOT on the hot path.
> It is only used on the setup functions.
> 
> If you think this is not a total waste of time, I will send a v2 moving
> it to the bottom.

I'd keep it next to dev. A bit of packing to save space is fine, 
but let's prioritize readability during the reshuffle.
Note that net-next is closed for the MW.