linux-kernel - Re: [PATCH 04/10] fpga: tests: add module descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6ab8b951-a2be-4434-8621-0b31d00608ad@linux.dev>
Date: Tue, 25 Mar 2025 18:06:51 +0100
From: Marco Pagani <marco.pagani@...ux.dev>
To: Arnd Bergmann <arnd@...nel.org>,
 Jeff Johnson <jeff.johnson@....qualcomm.com>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Masahiro Yamada <masahiroy@...nel.org>, Moritz Fischer <mdf@...nel.org>,
 Wu Hao <hao.wu@...el.com>, Xu Yilun <yilun.xu@...el.com>
Cc: Stephen Rothwell <sfr@...b.auug.org.au>, linux-next@...r.kernel.org,
 Arnd Bergmann <arnd@...db.de>, Tom Rix <trix@...hat.com>,
 Marco Pagani <marpagan@...hat.com>, Russ Weight <russ.weight@...ux.dev>,
 linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 04/10] fpga: tests: add module descriptions


On 2025-03-24 18:32, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Modules without a description now cause a warning:
> 
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fpga/tests/fpga-bridge-test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fpga/tests/fpga-mgr-test.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/fpga/tests/fpga-region-test.o
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Reviewed-by: Marco Pagani <marco.pagani@...ux.dev>

> ---
>  drivers/fpga/tests/fpga-bridge-test.c | 1 +
>  drivers/fpga/tests/fpga-mgr-test.c    | 1 +
>  drivers/fpga/tests/fpga-region-test.c | 1 +
>  3 files changed, 3 insertions(+)
> 
> diff --git a/drivers/fpga/tests/fpga-bridge-test.c b/drivers/fpga/tests/fpga-bridge-test.c
> index b9ab29809e96..124ba40e32b1 100644
> --- a/drivers/fpga/tests/fpga-bridge-test.c
> +++ b/drivers/fpga/tests/fpga-bridge-test.c
> @@ -170,4 +170,5 @@ static struct kunit_suite fpga_bridge_suite = {
>  
>  kunit_test_suite(fpga_bridge_suite);
>  
> +MODULE_DESCRIPTION("KUnit test for the FPGA Bridge");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/fpga/tests/fpga-mgr-test.c b/drivers/fpga/tests/fpga-mgr-test.c
> index 9cb37aefbac4..8748babb0504 100644
> --- a/drivers/fpga/tests/fpga-mgr-test.c
> +++ b/drivers/fpga/tests/fpga-mgr-test.c
> @@ -330,4 +330,5 @@ static struct kunit_suite fpga_mgr_suite = {
>  
>  kunit_test_suite(fpga_mgr_suite);
>  
> +MODULE_DESCRIPTION("KUnit test for the FPGA Manager");
>  MODULE_LICENSE("GPL");
> diff --git a/drivers/fpga/tests/fpga-region-test.c b/drivers/fpga/tests/fpga-region-test.c
> index 6a108cafded8..020ceac48509 100644
> --- a/drivers/fpga/tests/fpga-region-test.c
> +++ b/drivers/fpga/tests/fpga-region-test.c
> @@ -214,4 +214,5 @@ static struct kunit_suite fpga_region_suite = {
>  
>  kunit_test_suite(fpga_region_suite);
>  
> +MODULE_DESCRIPTION("KUnit test for the FPGA Region");
>  MODULE_LICENSE("GPL");