linux-kernel - Re: [PATCH v3 0/3] nvme_map_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <36e514f8-27a6-40e2-88dc-c2f985b0d04a@nvidia.com>
Date: Tue, 25 Mar 2025 17:27:55 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Caleb Sander Mateos <csander@...estorage.com>, Keith Busch
	<kbusch@...nel.org>, Jens Axboe <axboe@...nel.dk>, Christoph Hellwig
	<hch@....de>, Sagi Grimberg <sagi@...mberg.me>, Pavel Begunkov
	<asml.silence@...il.com>
CC: Xinyu Zhang <xizhang@...estorage.com>, "linux-nvme@...ts.infradead.org"
	<linux-nvme@...ts.infradead.org>, "io-uring@...r.kernel.org"
	<io-uring@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 0/3] nvme_map_user_request() cleanup

On 3/24/25 13:05, Caleb Sander Mateos wrote:
> The first commit removes a WARN_ON_ONCE() checking userspace values.
> The last 2 move code out of nvme_map_user_request() that belongs better
> in its callers, and move the fixed buffer import before going async.
> As discussed in [1], this allows an NVMe passthru operation submitted at
> the same time as a ublk zero-copy buffer unregister operation to succeed
> even if the initial issue goes async. This can improve performance of
> userspace applications submitting the operations together like this with
> a slow fallback path on failure. This is an alternate approach to [2],
> which moved the fixed buffer import to the io_uring layer.
>
> There will likely be conflicts with the parameter cleanup series Keith
> posted last month in [3].
>
> The series is based on block/for-6.15/io_uring, with commit 00817f0f1c45
> ("nvme-ioctl: fix leaked requests on mapping error") cherry-picked.
>
> [1]:https://lore.kernel.org/io-uring/20250321184819.3847386-1-csander@purestorage.com/T/#u
> [2]:https://lore.kernel.org/io-uring/20250321184819.3847386-4-csander@purestorage.com/
> [3]:https://lore.kernel.org/all/20250224182128.2042061-1-kbusch@meta.com/T/#u
>
> v3: Move the fixed buffer import before allocating a blk-mq request
>
> v2: Fix iov_iter value passed to nvme_map_user_request()

Looks good to me.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck