linux-kernel - Re: [PATCH RESEND 5/5] HID: multitouch: add device ID for Apple Touch Bar

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <219B5F93-611D-48FA-A4D9-F9B71401A57D@gmail.com>
Date: Tue, 25 Mar 2025 23:01:31 +0530
From: Aditya Garg <adityagarg1208@...il.com>
To: Benjamin Tissoires <bentiss@...nel.org>
Cc: admin@...eit.net, benjamin.tissoires@...hat.com, GARGADITYA08@...e.com,
 jikos@...nel.org, jkosina@...e.com, kekrby@...il.com,
 linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
 orlandoch.dev@...il.com
Subject: Re: [PATCH RESEND 5/5] HID: multitouch: add device ID for Apple Touch Bar



> On 25 Mar 2025, at 10:59 PM, Benjamin Tissoires <bentiss@...nel.org> wrote:
> 
> On Mar 25 2025, Aditya Garg wrote:
>> Yes I can move hid_find_field to the original location as well. But, I would not want to devm_kzalloc as well unnecessarily if the touchbar is in the basic mode instead of drm mode which will cause this -ENODEV to be executed right?
> 
> It shouldn't matter. hid_core calls devres_open_group() before calling
> .probe(), and calls devres_release_group() on failure. So yes, we'll
> allocate a piece of memory and release it after, but it's not something
> uncommon.

Fair. I'll send a v2