linux-kernel - Re: [PATCH net-next] net: move replay logic to tc_modify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANn89iL9PMzJgMuObe==o=OHsHsVSVUu81_Wjp2daK92Lhu=fA@mail.gmail.com>
Date: Tue, 25 Mar 2025 19:01:49 +0100
From: Eric Dumazet <edumazet@...gle.com>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, kuba@...nel.org, 
	pabeni@...hat.com, linux-kernel@...r.kernel.org, jhs@...atatu.com, 
	xiyou.wangcong@...il.com, jiri@...nulli.us, horms@...nel.org
Subject: Re: [PATCH net-next] net: move replay logic to tc_modify_qdisc

On Tue, Mar 25, 2025 at 6:54 PM Stanislav Fomichev <sdf@...ichev.me> wrote:
>
> Eric reports that by the time we call netdev_lock_ops after
> rtnl_unlock/rtnl_lock, the dev might point to an invalid device.
> As suggested by Jakub in [0], move rtnl lock/unlock and request_module
> outside of qdisc_create. This removes extra complexity with relocking
> the netdev.
>
> 0: https://lore.kernel.org/netdev/20250325032803.1542c15e@kernel.org/
>
> Fixes: a0527ee2df3f ("net: hold netdev instance lock during qdisc ndo_setup_tc")
> Reported-by: Eric Dumazet <edumazet@...gle.com>
> Link: https://lore.kernel.org/netdev/20250305163732.2766420-1-sdf@fomichev.me/T/#me8dfd778ea4c4463acab55644e3f9836bc608771
> Signed-off-by: Stanislav Fomichev <sdf@...ichev.me>

Nice, thank you !

Reviewed-by: Eric Dumazet <edumazet@...gle.com>