linux-kernel - Re: [PATCH 1/2] dt-bindings: display: panel: Add Visionox G2647FB105

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <7f13200d-9310-46a2-8424-51dcb0f2dbb7@kernel.org>
Date: Tue, 25 Mar 2025 19:21:09 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Danila Tikhonov <danila@...xyga.com>
Cc: Alexander Baransky <sanyapilot496@...il.com>, neil.armstrong@...aro.org,
 quic_jesszhan@...cinc.com, maarten.lankhorst@...ux.intel.com,
 mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com, simona@...ll.ch,
 robh@...nel.org, dri-devel@...ts.freedesktop.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: display: panel: Add Visionox G2647FB105

On 25/03/2025 19:16, Danila Tikhonov wrote:
>>> +  vsp-supply:
>>> +    description: Positive source voltage rail
>> Are you sure these are real voltage rails on the device? Weirdly similar
>> to some old Samsung AMOLED panels...
> Hello Krzysztof,
> 
> I was somewhat intrigued by your observation, especially since I have
> some schematics for this device. The patch correctly adds four
> regulators – ibb, lab, vdd (3p0), and vio (1p8).
> 
> This situation arises from Xiaomi’s tendency to use different panels in
> various revisions of the same device. Although, AFAIK, the
> sm7150-xiaomi-toco/tucana was released with only one possible variation
> (which this series adds), the sm7150-xiaomi-davinci offers a different
> perspective. The latter was initially produced with a samsung,ams639rq08
> panel (which I had added previously), yet official service centers have
> replaced the factory panel with the visionox,g1639fp106 during repairs.
> This suggests that, in terms of power configuration, the
> samsung,ams639rq08 and the visionox,g1639fp106 panels are effectively
> identical.
> 
> It is therefore likely that the visionox,g2647fb105 from this series
> follows the same way.
> 
> Nevertheless, it is reassuring that I can confirm these findings with
> the schematics rather than relying on mere guesswork xD

Great, appreciated, thanks for checking. Some parts of above -
similarities including replacement of factory panel - might be good for
commit msg. Please add them. With that and simplifying the commit
sentence style:

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof