linux-kernel - Re: [PATCH v3 2/2] ACPI: PNP: Add Intel OC Watchdog IDs to non-PNP device list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jh1jJy+YRMtLDnYqAhPrN2Pox+NY0Vqh_uqb7F=NwqEg@mail.gmail.com>
Date: Tue, 25 Mar 2025 19:59:14 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Diogo Ivo <diogo.ivo@...mens.com>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, 
	Wim Van Sebroeck <wim@...ux-watchdog.org>, Guenter Roeck <linux@...ck-us.net>, 
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, 
	linux-watchdog@...r.kernel.org, jan.kiszka@...mens.com, 
	benedikt.niedermayr@...mens.com
Subject: Re: [PATCH v3 2/2] ACPI: PNP: Add Intel OC Watchdog IDs to non-PNP
 device list

On Tue, Mar 25, 2025 at 6:19 PM Diogo Ivo <diogo.ivo@...mens.com> wrote:
>
> Hello,
>
> On 3/17/25 10:55 AM, Diogo Ivo wrote:
> > Intel Over-Clocking Watchdogs are described in ACPI tables by both the
> > generic PNP0C02 _CID and their ACPI _HID. The presence of the _CID then
> > causes the PNP scan handler to attach to the watchdog, preventing the
> > actual watchdog driver from binding. Address this by adding the ACPI
> > _HIDs to the list of non-PNP devices, so that the PNP scan handler is
> > bypassed.
> >
> > Note that these watchdogs can be described by multiple _HIDs for what
> > seems to be identical hardware. This commit is not a complete list of
> > all the possible watchdog ACPI _HIDs.
> >
> > Signed-off-by: Diogo Ivo <diogo.ivo@...mens.com>
> > ---
> > v2->v3:
> >   - Reword the commit message to clarify purpose of patch
> > ---
> > ---
> >   drivers/acpi/acpi_pnp.c | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/drivers/acpi/acpi_pnp.c b/drivers/acpi/acpi_pnp.c
> > index 01abf26764b00c86f938dea2ed138424f041f880..3f5a1840f573303c71f5d579e32963a5b29d2587 100644
> > --- a/drivers/acpi/acpi_pnp.c
> > +++ b/drivers/acpi/acpi_pnp.c
> > @@ -355,8 +355,10 @@ static bool acpi_pnp_match(const char *idstr, const struct acpi_device_id **matc
> >    * device represented by it.
> >    */
> >   static const struct acpi_device_id acpi_nonpnp_device_ids[] = {
> > +     {"INT3F0D"},
> >       {"INTC1080"},
> >       {"INTC1081"},
> > +     {"INTC1099"},
> >       {""},
> >   };
> >
> >
>
> Gentle ping on this patch.

Do you want me to pick it up or do you want to route it through a
different tree?