linux-kernel - Re: [PATCH v6 4/4] drm/tidss: Add OLDI bridge support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2b5bd03f2c8000b0bbf10c649efc5c080fde1a91.camel@siemens.com>
Date: Tue, 25 Mar 2025 19:05:21 +0000
From: "Sverdlin, Alexander" <alexander.sverdlin@...mens.com>
To: "robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"jyri.sarha@....fi" <jyri.sarha@....fi>, "aradhya.bhatia@...ux.dev"
	<aradhya.bhatia@...ux.dev>, "tomi.valkeinen@...asonboard.com"
	<tomi.valkeinen@...asonboard.com>
CC: "francesco@...cini.it" <francesco@...cini.it>, "praneeth@...com"
	<praneeth@...com>, "tzimmermann@...e.de" <tzimmermann@...e.de>,
	"laurent.pinchart@...asonboard.com" <laurent.pinchart@...asonboard.com>,
	"mripard@...nel.org" <mripard@...nel.org>, "simona@...ll.ch"
	<simona@...ll.ch>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "j-choudhary@...com" <j-choudhary@...com>,
	"dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "devarsht@...com"
	<devarsht@...com>, "maarten.lankhorst@...ux.intel.com"
	<maarten.lankhorst@...ux.intel.com>, "airlied@...il.com" <airlied@...il.com>,
	"nm@...com" <nm@...com>, "u-kumar1@...com" <u-kumar1@...com>,
	"vigneshr@...com" <vigneshr@...com>
Subject: Re: [PATCH v6 4/4] drm/tidss: Add OLDI bridge support

Thank you for your work Aradhya!

On Wed, 2025-02-26 at 23:43 +0530, Aradhya Bhatia wrote:
> From: Aradhya Bhatia <a-bhatia1@...com>
> 
> The AM62x and AM62Px SoCs feature 2 OLDI TXes each, which makes it
> possible to connect them in dual-link or cloned single-link OLDI display
> modes. The current OLDI support in tidss_dispc.c can only support for
> a single OLDI TX, connected to a VP and doesn't really support
> configuration of OLDIs in the other modes. The current OLDI support in
> tidss_dispc.c also works on the principle that the OLDI output can only
> be served by one, and only one, DSS video-port. This isn't the case in
> the AM62Px SoC, where there are 2 DSS controllers present that share the
> OLDI TXes.
> 
> Having their own devicetree and their own bridge entity will help
> support the various display modes and sharing possiblilities of the OLDI
> hardware.
> 
> For all these reasons, add support for the OLDI TXes as DRM bridges.
> 
> Reviewed-by: Tomi Valkeinen <tomi.valkeinen@...asonboard.com>
> Signed-off-by: Aradhya Bhatia <a-bhatia1@...com>
> Signed-off-by: Aradhya Bhatia <aradhya.bhatia@...ux.dev>

I've applied the series onto next-20250320 (+ required DT changes from
the TI tree + the parts required to wire the particular panel) and tested
with single channel AUO 800x480 LVDS panel on OLDI0. LGTM!

Tested-by: Alexander Sverdlin <alexander.sverdlin@...mens.com>

> ---
>  drivers/gpu/drm/tidss/Makefile           |   3 +-
>  drivers/gpu/drm/tidss/tidss_dispc.c      |  24 +-
>  drivers/gpu/drm/tidss/tidss_dispc.h      |   5 +
>  drivers/gpu/drm/tidss/tidss_dispc_regs.h |  14 +
>  drivers/gpu/drm/tidss/tidss_drv.c        |   9 +
>  drivers/gpu/drm/tidss/tidss_drv.h        |   5 +
>  drivers/gpu/drm/tidss/tidss_oldi.c       | 568 +++++++++++++++++++++++
>  drivers/gpu/drm/tidss/tidss_oldi.h       |  42 ++
>  8 files changed, 668 insertions(+), 2 deletions(-)
>  create mode 100644 drivers/gpu/drm/tidss/tidss_oldi.c
>  create mode 100644 drivers/gpu/drm/tidss/tidss_oldi.h
> 

-- 
Alexander Sverdlin
Siemens AG
www.siemens.com