linux-kernel - Re: [PATCH v7 01/28] lsm: Add audit_log_lsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250325.3932dbc7b476@gnoack.org>
Date: Tue, 25 Mar 2025 20:35:43 +0100
From: Günther Noack <gnoack3000@...il.com>
To: Mickaël Salaün <mic@...ikod.net>
Cc: Eric Paris <eparis@...hat.com>, Paul Moore <paul@...l-moore.com>,
	Günther Noack <gnoack@...gle.com>,
	"Serge E . Hallyn" <serge@...lyn.com>,
	Ben Scarlato <akhna@...gle.com>,
	Casey Schaufler <casey@...aufler-ca.com>,
	Charles Zaffery <czaffery@...lox.com>,
	Daniel Burgener <dburgener@...ux.microsoft.com>,
	Francis Laniel <flaniel@...ux.microsoft.com>,
	James Morris <jmorris@...ei.org>, Jann Horn <jannh@...gle.com>,
	Jeff Xu <jeffxu@...gle.com>,
	Jorge Lucangeli Obes <jorgelo@...gle.com>,
	Kees Cook <kees@...nel.org>,
	Konstantin Meskhidze <konstantin.meskhidze@...wei.com>,
	Matt Bobrowski <mattbobrowski@...gle.com>,
	Matthieu Buffet <matthieu@...fet.re>,
	Mikhail Ivanov <ivanov.mikhail1@...wei-partners.com>,
	Phil Sutter <phil@....cc>,
	Praveen K Paladugu <prapal@...ux.microsoft.com>,
	Robert Salvet <robert.salvet@...lox.com>,
	Shervin Oloumi <enlightened@...gle.com>, Song Liu <song@...nel.org>,
	Tahera Fahimi <fahimitahera@...il.com>, Tingmao Wang <m@...wtm.org>,
	Tyler Hicks <code@...icks.com>, audit@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-security-module@...r.kernel.org
Subject: Re: [PATCH v7 01/28] lsm: Add audit_log_lsm_data() helper

On Thu, Mar 20, 2025 at 08:06:50PM +0100, Mickaël Salaün wrote:
> diff --git a/security/lsm_audit.c b/security/lsm_audit.c
> index 52db886dbba8..a61c7ebdb6a7 100644
> --- a/security/lsm_audit.c
> +++ b/security/lsm_audit.c
> @@ -431,6 +425,21 @@ static void dump_common_audit_data(struct audit_buffer *ab,
>  	} /* switch (a->type) */
>  }
>  
> +/**
> + * dump_common_audit_data - helper to dump common audit data
> + * @ab : the audit buffer
> + * @a : common audit data
> + */

I was tempted to remark on the unusual documentation style with the
extra space before the colon, but I see that it has prior art in the
same file...

> +static void dump_common_audit_data(struct audit_buffer *ab,
> +				   const struct common_audit_data *a)
> +{
> +	char comm[sizeof(current->comm)];
> +
> +	audit_log_format(ab, " pid=%d comm=", task_tgid_nr(current));
> +	audit_log_untrustedstring(ab, get_task_comm(comm, current));
> +	audit_log_lsm_data(ab, a);
> +}
> +
>  /**
>   * common_lsm_audit - generic LSM auditing function
>   * @a:  auxiliary audit data
> -- 
> 2.49.0
> 

Reviewed-by: Günther Noack <gnoack3000@...il.com>