linux-kernel - Re: [EXTERNAL] Re: [PATCH 2/3] net: mana: Implement set_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6396c1f7-756d-476a-833e-7ea35ae41da8@lunn.ch>
Date: Tue, 25 Mar 2025 20:58:54 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Haiyang Zhang <haiyangz@...rosoft.com>
Cc: Jakub Kicinski <kuba@...nel.org>,
	Erni Sri Satya Vennela <ernis@...ux.microsoft.com>,
	KY Srinivasan <kys@...rosoft.com>,
	"wei.liu@...nel.org" <wei.liu@...nel.org>,
	Dexuan Cui <decui@...rosoft.com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	Long Li <longli@...rosoft.com>,
	Konstantin Taranov <kotaranov@...rosoft.com>,
	"horms@...nel.org" <horms@...nel.org>,
	"brett.creeley@....com" <brett.creeley@....com>,
	"surenb@...gle.com" <surenb@...gle.com>,
	"schakrabarti@...ux.microsoft.com" <schakrabarti@...ux.microsoft.com>,
	"kent.overstreet@...ux.dev" <kent.overstreet@...ux.dev>,
	"shradhagupta@...ux.microsoft.com" <shradhagupta@...ux.microsoft.com>,
	"erick.archer@...look.com" <erick.archer@...look.com>,
	"rosenp@...il.com" <rosenp@...il.com>,
	"linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	Paul Rosswurm <paulros@...rosoft.com>
Subject: Re: [EXTERNAL] Re: [PATCH 2/3] net: mana: Implement
 set_link_ksettings in ethtool for speed

> This patch is just to support the ethtool option for the speed.
> And seems there is no option on ethtool to reset NIC to the default
> speed?

There is no such thing as default speed. Speed is either:

1) Negotiated with the link partner, picking the highest speed link
modes both partners support

2) Forced to a specific speed, based on one of the link modes the
interfaces supports.

Since you don't have link modes, you are abusing the API. You should
choose a different API which actually fits what you are doing,
configuring a leaky bucket shaper.

	Andrew