linux-kernel - Re: [GIT PULL] Rust `hrtimer` support for v6.15

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kGAbhSi6y-2iouuRYhEZ9rGnDmQKJo8YwYjcaM+P5FpQ@mail.gmail.com>
Date: Tue, 25 Mar 2025 21:03:44 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Andreas Hindborg <a.hindborg@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Anna-Maria Behnsen <anna-maria@...utronix.de>, 
	Frederic Weisbecker <frederic@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, linux-kernel@...r.kernel.org, 
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>
Subject: Re: [GIT PULL] Rust `hrtimer` support for v6.15

On Fri, Mar 21, 2025 at 1:14 PM Andreas Hindborg <a.hindborg@...nel.org> wrote:
>
> As discussed, I fixed the UB you fund in:
>
>   rust: hrtimer: allow timer restart from timer handler
>
> by casting to `u32` when assigning enum values. The commits below this
> commit are unchanged, the later commits were replayed on top of the
> changed commit.

I reduced it and filled an issue upstream:

    https://github.com/rust-lang/rust-bindgen/issues/3179

And I sent a potential patch to deal with this cleanly in a single
place (as long as the C headers allow for it, which in your case it
does), please see:

    https://lore.kernel.org/rust-for-linux/20250325184309.97170-1-ojeda@kernel.org/

By the way, it wasn't UB, no? i.e. the UB one was the parsing patch on
the modules series, which we discussed roughly at the same time.

I hope that helps!

Cheers,
Miguel