linux-kernel - Re: [PATCH] ACPI: platform_profile: Optimize _aggregate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D8PM9ESWNN10.QARF2AMDMH6W@gmail.com>
Date: Tue, 25 Mar 2025 17:06:58 -0300
From: "Kurt Borja" <kuurtb@...il.com>
To: "Armin Wolf" <W_Armin@....de>, "Rafael J. Wysocki" <rafael@...nel.org>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, "Mark
 Pearson" <mpearson-lenovo@...ebb.ca>
Cc: "Mario Limonciello" <mario.limonciello@....com>, "Len Brown"
 <lenb@...nel.org>, <linux-acpi@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI: platform_profile: Optimize _aggregate_choices()

On Tue Mar 25, 2025 at 4:36 PM -03, Armin Wolf wrote:
> Am 22.03.25 um 22:03 schrieb Kurt Borja:
>
>> Choices aggregates passed to _aggregate_choices() are already filled
>> with ones, therefore we can avoid copying a new bitmap on the first
>> iteration.
>>
>> This makes setting the PLATFORM_PROFILE_LAST bit on aggregates
>> unnecessary, so drop it as well.
>>
>> While at it, add a couple empty lines to improve style.
>>
> Please add a comment to signal future developers that the bitmap needs to be filled with ones
> before being passed to _aggregate_choices().

Sure, I'll mention it in the kernel-doc for v2.

>
> With this being addressed:
>
> Reviewed-by: Armin Wolf <W_Armin@....de>

Thank you Mario and Armin for the reviews!

-- 
 ~ Kurt