linux-kernel - Re: [PATCH] binder: fix offset calculation in debug log

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <dbx81pukx3h7.fsf@ynaffit-start.c.googlers.com>
Date: Tue, 25 Mar 2025 20:25:08 +0000
From: "Tiffany Y. Yang" <ynaffit@...gle.com>
To: Carlos Llamas <cmllamas@...gle.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,  Arve Hjønnevåg
 <arve@...roid.com>,  Todd Kjos <tkjos@...roid.com>,  Martijn Coenen
 <maco@...roid.com>,  Joel Fernandes <joel@...lfernandes.org>,  Christian
 Brauner <brauner@...nel.org>,  Suren Baghdasaryan <surenb@...gle.com>,
  Alice Ryhl <aliceryhl@...gle.com>,  linux-kernel@...r.kernel.org,
  kernel-team@...roid.com,  stable@...r.kernel.org
Subject: Re: [PATCH] binder: fix offset calculation in debug log

Carlos Llamas <cmllamas@...gle.com> writes:

> The vma start address should be substracted from the buffer's user data
> address and not the other way around.
>
> Cc: Tiffany Y. Yang <ynaffit@...gle.com>
> Cc: stable@...r.kernel.org
> Fixes: 162c79731448 ("binder: avoid user addresses in debug logs")
> Signed-off-by: Carlos Llamas <cmllamas@...gle.com>

Reviewed-by: Tiffany Y. Yang <ynaffit@...gle.com>

> ---
>  drivers/android/binder.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/android/binder.c b/drivers/android/binder.c
> index 76052006bd87..5fc2c8ee61b1 100644
> --- a/drivers/android/binder.c
> +++ b/drivers/android/binder.c
> @@ -6373,7 +6373,7 @@ static void print_binder_transaction_ilocked(struct seq_file *m,
>  		seq_printf(m, " node %d", buffer->target_node->debug_id);
>  	seq_printf(m, " size %zd:%zd offset %lx\n",
>  		   buffer->data_size, buffer->offsets_size,
> -		   proc->alloc.vm_start - buffer->user_data);
> +		   buffer->user_data - proc->alloc.vm_start);
>  }
>  
>  static void print_binder_work_ilocked(struct seq_file *m,