linux-kernel - Re: [PATCH v4 1/1] scsi: ufs: core: add device level exception support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c5ab13ec-f650-ea10-5cb8-d6a2ddf1e825@quicinc.com>
Date: Tue, 25 Mar 2025 15:15:47 -0700
From: "Bao D. Nguyen" <quic_nguyenb@...cinc.com>
To: Arthur Simchaev <Arthur.Simchaev@...disk.com>,
        "quic_cang@...cinc.com"
	<quic_cang@...cinc.com>,
        "quic_nitirawa@...cinc.com"
	<quic_nitirawa@...cinc.com>,
        "bvanassche@....org" <bvanassche@....org>,
        "avri.altman@....com" <avri.altman@....com>,
        "peter.wang@...iatek.com"
	<peter.wang@...iatek.com>,
        "manivannan.sadhasivam@...aro.org"
	<manivannan.sadhasivam@...aro.org>,
        "minwoo.im@...sung.com"
	<minwoo.im@...sung.com>,
        "adrian.hunter@...el.com" <adrian.hunter@...el.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        Alim Akhtar
	<alim.akhtar@...sung.com>,
        "James E.J. Bottomley"
	<James.Bottomley@...senPartnership.com>,
        Matthias Brugger
	<matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno
	<angelogioacchino.delregno@...labora.com>,
        Bean Huo <beanhuo@...ron.com>,
        Keoseong Park <keosung.park@...sung.com>,
        Ziqi Chen
	<quic_ziqichen@...cinc.com>,
        Al Viro <viro@...iv.linux.org.uk>,
        "Gwendal
 Grignou" <gwendal@...omium.org>,
        Eric Biggers <ebiggers@...gle.com>,
        open
 list <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC
 support:Keyword:mediatek" <linux-arm-kernel@...ts.infradead.org>,
        "moderated
 list:ARM/Mediatek SoC support:Keyword:mediatek"
	<linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v4 1/1] scsi: ufs: core: add device level exception
 support

On 3/25/2025 9:33 AM, Arthur Simchaev wrote:
> Hi Bao
> 
> I think adding "struct utp_upiu_query_response_v4_0" is redundant and not correct for flags upiu response .
> You can use "struct utp_upiu_query_v4_0"
> 
Hi Arthur,
This is not a flags attribute. This is for a Query Read 64-bit Attribute 
data. In the existing code, we do not have a read 64-bit attribute, so 
adding this new code would also allow future re-use.

The new "struct utp_upiu_query_response_v4_0" would improve readability 
because it is formatted exactly as how the jedec standard defines for 
Attribute Read. We won't need to use type cast to get the 64-bit value.
There would be no issue with efficiency because the same machine code 
would be generated.

The existing "struct utp_upiu_query_v4_0" probably has a bug in it. It 
does not use the  __attribute__((__packed__)) attribute. The compiler is 
free to add padding in this structure, resulting in the read attribute 
value being incorrect. I plan to provide a separate patch to fix this issue.

Thanks, Bao