linux-kernel - Re: [PATCH] Add support for CCD temperatures in AMD 1Ah CPUs model 0x40..0x4f

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e6301e40-b925-4dcf-9306-d8b4ae6b70ce@roeck-us.net>
Date: Tue, 25 Mar 2025 15:36:14 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: David Hows <david@...s.id.au>
Cc: Clemens Ladisch <clemens@...isch.de>, Jean Delvare <jdelvare@...e.com>,
 linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Add support for CCD temperatures in AMD 1Ah CPUs model
 0x40..0x4f

On 3/25/25 12:04, David Hows wrote:
> Thank you.
> 
> Should i make changes and re-submit?
> 

Yes, please.

Thanks,
Guenter

>> On 25 Mar 2025, at 11:46 pm, Guenter Roeck <linux@...ck-us.net> wrote:
>>
>> Hi,
>>
>>> On 3/25/25 04:14, David Hows wrote:
>>> ---
>>
>> The subject should start with "hwmon: (k10temp)". Also, it should really say
>> something like "Add support for Zen5 Ryzen Desktop" or similar to better
>> describe what it actually does.
>>
>> Every patch needs a description. Please see
>> Documentation/process/submitting-patches.rst for guidance.
>>
>> Thanks,
>> Guenter
>>
>>>   drivers/hwmon/k10temp.c | 7 +++++++
>>>   1 file changed, 7 insertions(+)
>>> diff --git a/drivers/hwmon/k10temp.c b/drivers/hwmon/k10temp.c
>>> index d0b4cc9a5011..cc2ad7a324f9 100644
>>> --- a/drivers/hwmon/k10temp.c
>>> +++ b/drivers/hwmon/k10temp.c
>>> @@ -502,6 +502,13 @@ static int k10temp_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>>>               k10temp_get_ccd_support(data, 12);
>>>               break;
>>>           }
>>> +    } else if (boot_cpu_data.x86 == 0x1a) {
>>> +        switch (boot_cpu_data.x86_model) {
>>> +        case 0x40 ... 0x4f:    /* Zen5 Ryzen Desktop*/
>>> +            data->ccd_offset = 0x308;
>>> +            k10temp_get_ccd_support(data, 8);
>>> +            break;
>>> +        }
>>>       }
>>>         for (i = 0; i < ARRAY_SIZE(tctl_offset_table); i++) {