[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <Z-JQwWSdyVXkttUI@gmail.com>
Date: Tue, 25 Mar 2025 07:44:17 +0100
From: Ingo Molnar <mingo@...nel.org>
To: Linus Torvalds <torvalds@...ux-foundation.org>
Cc: linux-kernel@...r.kernel.org, the arch/x86 maintainers <x86@...nel.org>,
Ard Biesheuvel <ardb@...nel.org>,
Peter Zijlstra <peterz@...radead.org>,
"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [GIT PULL] x86/build updates for v6.15
* Linus Torvalds <torvalds@...ux-foundation.org> wrote:
> On Sat, 22 Mar 2025 at 04:46, Ingo Molnar <mingo@...nel.org> wrote:
> >
> > - Drop CRC-32 checksum and the build tool that generates it
> > (Ard Biesheuvel)
>
> Hmm. I didn't notice this during the merge process, but not too long
> afterwards it became obvious that this caused problems.
>
> I've committed the fix separately: commit 2df0c02dab82 ("x86 boot
> build: make git ignore stale 'tools' directory").
Thank you!
> Please don't just mindlessly remove .gitignore entries for generated
> files.
>
> Because even if *you* may have removed the file, the generated files
> don't magically disappear from everybody else, and when the gitignore
> entry is gone, you are now setting other developers up for mistakes.
Indeed. I never saw this warning, as the directory was gone, but on a
build box I have:
Untracked files:
...
arch/x86/boot/tools/
And I can see how this can then be added back in spuriously.
Thanks,
Ingo
Powered by blists - more mailing lists