linux-kernel - Re: [PATCH 1/6] dt-bindings: pci: cadence: Add property "hpa" for PCIe controllers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <53eb9d35-2b7c-4742-af18-e7b0fb1cdcfe@kernel.org>
Date: Tue, 25 Mar 2025 07:57:33 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Manikandan Karunakaran Pillai <mpillai@...ence.com>,
 "lpieralisi@...nel.org" <lpieralisi@...nel.org>,
 "manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
 "bhelgaas@...gle.com" <bhelgaas@...gle.com>, "kw@...ux.com" <kw@...ux.com>,
 "robh@...nel.org" <robh@...nel.org>,
 "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
 Milind Parab <mparab@...ence.com>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
 "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: Re: [PATCH 1/6] dt-bindings: pci: cadence: Add property "hpa" for
 PCIe controllers

On 25/03/2025 04:16, Manikandan Karunakaran Pillai wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@...nel.org>
>> Sent: Monday, March 24, 2025 9:29 PM
>> To: Manikandan Karunakaran Pillai <mpillai@...ence.com>;
>> lpieralisi@...nel.org; manivannan.sadhasivam@...aro.org;
>> bhelgaas@...gle.com; kw@...ux.com; robh@...nel.org;
>> devicetree@...r.kernel.org
>> Cc: linux-kernel@...r.kernel.org; linux-pci@...r.kernel.org
>> Subject: Re: [PATCH 1/6] dt-bindings: pci: cadence: Add property "hpa" for PCIe
>> controllers
>>
>> EXTERNAL MAIL
>>
>>
>> On 24/03/2025 10:08, Manikandan Karunakaran Pillai wrote:
>>> Document the newly added property "hpa" for Cadence PCIe controllers
>>> in Documentation/devicetree/bindings/pci/ for Root Port and Endpoint
>>> configurations
>>
>> Drop the path, pointless.
> Ok
>>
>>>
>>
>> Please run scripts/checkpatch.pl on the patches and fix reported warnings.
>> After that, run also 'scripts/checkpatch.pl --strict' on the patches and
>> (probably) fix more warnings. Some warnings can be ignored, especially from -
>> -strict run, but the code here looks like it needs a fix. Feel free to get in touch if
>> the warning is not clear.
>>
> 
> The scripts/checkpatch.pl has been run  with and without --strict. With the --strict option
> 4 checks are generated on 1 patch(patch 0002 of the series), which can be ignored. There are 
> no code fixes required for these checks. The rest of the 'scripts/checkpatch.pl' 
> is clean.

No, it's not. The patch has obvious style violations.


> 
>> <form letter>
>> Please use scripts/get_maintainers.pl to get a list of necessary people and lists
>> to CC (and consider --no-git-fallback argument, so you will not CC people just
>> because they made one commit years ago). It might happen, that command
>> when run on an older kernel, gives you outdated entries. Therefore please be
>> sure you base your patches on recent Linux kernel.
> 
> Ok
> 
>>
>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so
>> fix your workflow. Tools might also fail if you work on some ancient tree (don't,
>> instead use mainline) or work on fork of kernel (don't, instead use mainline).
>> Just use b4 and everything should be fine, although remember about `b4 prep
>> --auto-to-cc` if you added new patches to the patchset.
>> </form letter>
>>
> I used an earlier list generated. Will take care to generate the list on latest tree.

That's not the correct process. Why would you Cc maintainers from 10
years ago?


Best regards,
Krzysztof