linux-kernel - Re: [PATCH v6 0/6] Enable IPQ5018 PCI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <DS7PR19MB88834DFB6D5E574BA89D5A5A9DA72@DS7PR19MB8883.namprd19.prod.outlook.com>
Date: Tue, 25 Mar 2025 11:55:00 +0400
From: George Moussalem <george.moussalem@...look.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Vinod Koul <vkoul@...nel.org>, Kishon Vijay Abraham I
 <kishon@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Nitheesh Sekar <quic_nsekar@...cinc.com>,
 Varadarajan Narayanan <quic_varada@...cinc.com>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Lorenzo Pieralisi <lpieralisi@...nel.org>,
 Krzysztof Wilczyński <kw@...ux.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, linux-arm-msm@...r.kernel.org,
 linux-phy@...ts.infradead.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org,
 20250317100029.881286-2-quic_varada@...cinc.com,
 Sricharan Ramabadhran <quic_srichara@...cinc.com>
Subject: Re: [PATCH v6 0/6] Enable IPQ5018 PCI support



On 3/24/25 11:47, Krzysztof Kozlowski wrote:
> On Fri, Mar 21, 2025 at 04:14:38PM +0400, George Moussalem wrote:
>> This patch series adds the relevant phy and controller
>> DT configurations for enabling PCI gen2 support
>> on IPQ5018. IPQ5018 has two phys and two controllers,
>> one dual-lane and one single-lane.
>>
>> Last patch series (v3) submitted dates back to August 30, 2024.
>> As I've worked to add IPQ5018 platform support in OpenWrt, I'm
>> continuing the efforts to add Linux kernel support.
>>
>> Signed-off-by: George Moussalem <george.moussalem@...look.com>
>> ---
>> Changes in v6:
>> - Fixed issues reported by 'make dt_bindings_check' as per Rob's bot
>> - Removed Krzysztof's Ack-tag on
> 
> Why?

In v5, I modified dt bindings (patch 1) to add descriptions and separate 
conditions for ipq5018 and ipq5332 as they have different nr of clocks 
and resets but left your tag in there. I removed it in v6 to run the 
changes past you again.

I intend to send the next version with comments addressed in patch 5 (to 
add a comment above the max-link-speed property). Anything else you 
would like to see addressed?

> 
> Again, I cannot compare this serie:
> 
>    b4 diff '20250321-ipq5018-pcie-v6-0-b7d659a76205@...look.com'
>    Grabbing thread from lore.kernel.org/all/20250321-ipq5018-pcie-v6-0-b7d659a76205@...look.com/t.mbox.gz
>    Checking for older revisions
>    Grabbing search results from lore.kernel.org
>    Nothing matching that query.
>    ---
>    Analyzing 12 messages in the thread
>    Could not find lower series to compare against.
> 

I tried 'b4 prep -n <topical branch> -F <message-ID>' to try and preseve 
the history but that didn't work, unfortunately. Instead I used -f and 
forked it off the master branch of linux-next.

> 
> 

Best regards,
George