linux-kernel - RE: [PATCH v1 3/5] PCI: imx6: Workaround i.MX95 PCIe may not exit L23 ready

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <AS8PR04MB86765138FE183551D570AAE58CA72@AS8PR04MB8676.eurprd04.prod.outlook.com>
Date: Tue, 25 Mar 2025 08:08:04 +0000
From: Hongxing Zhu <hongxing.zhu@....com>
To: Frank Li <frank.li@....com>
CC: "l.stach@...gutronix.de" <l.stach@...gutronix.de>, "lpieralisi@...nel.org"
	<lpieralisi@...nel.org>, "kw@...ux.com" <kw@...ux.com>,
	"manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
	"robh@...nel.org" <robh@...nel.org>, "bhelgaas@...gle.com"
	<bhelgaas@...gle.com>, "shawnguo@...nel.org" <shawnguo@...nel.org>,
	"s.hauer@...gutronix.de" <s.hauer@...gutronix.de>, "kernel@...gutronix.de"
	<kernel@...gutronix.de>, "festevam@...il.com" <festevam@...il.com>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1 3/5] PCI: imx6: Workaround i.MX95 PCIe may not exit L23
 ready

> -----Original Message-----
> From: Frank Li <frank.li@....com>
> Sent: 2025年3月25日 3:14
> To: Hongxing Zhu <hongxing.zhu@....com>
> Cc: l.stach@...gutronix.de; lpieralisi@...nel.org; kw@...ux.com;
> manivannan.sadhasivam@...aro.org; robh@...nel.org;
> bhelgaas@...gle.com; shawnguo@...nel.org; s.hauer@...gutronix.de;
> kernel@...gutronix.de; festevam@...il.com; linux-pci@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; imx@...ts.linux.dev;
> linux-kernel@...r.kernel.org
> Subject: Re: [PATCH v1 3/5] PCI: imx6: Workaround i.MX95 PCIe may not exit
> L23 ready
> 
> On Mon, Mar 24, 2025 at 02:26:45PM +0800, Richard Zhu wrote:
> > Workaround for ERR051624: The Controller Without Vaux Cannot Exit L23
> 
> provide a errata link here.
Up to now, I only get the following document updates information.
" This is being converted to Docs update and will be added to init sequence
 in Reference Manual."
Would add the errata link after I find it.
Thanks.

Best Regards
Richard Zhu
> 
> ERR051624: ...
> 
> The words after ERR051624 is descript errata itself, not workaround.
> 
> > Ready Through Beacon or PERST# De-assertion
> >
> > When the auxiliary power is not available, the controller cannot exit
> > from L23 Ready with beacon or PERST# de-assertion when main power is
> > not removed.
> >
> > Workaround: Set SS_RW_REG_1[SYS_AUX_PWR_DET] to 1.
> >
> > Signed-off-by: Richard Zhu <hongxing.zhu@....com>
> > ---
> >  drivers/pci/controller/dwc/pci-imx6.c | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-imx6.c
> > b/drivers/pci/controller/dwc/pci-imx6.c
> > index 0f42ab63f5ad..52aa8bd66cde 100644
> > --- a/drivers/pci/controller/dwc/pci-imx6.c
> > +++ b/drivers/pci/controller/dwc/pci-imx6.c
> > @@ -48,6 +48,8 @@
> >  #define IMX95_PCIE_SS_RW_REG_0			0xf0
> >  #define IMX95_PCIE_REF_CLKEN			BIT(23)
> >  #define IMX95_PCIE_PHY_CR_PARA_SEL		BIT(9)
> > +#define IMX95_PCIE_SS_RW_REG_1			0xf4
> > +#define IMX95_PCIE_SYS_AUX_PWR_DET		BIT(31)
> >
> >  #define IMX95_PE0_GEN_CTRL_1			0x1050
> >  #define IMX95_PCIE_DEVICE_TYPE			GENMASK(3, 0)
> > @@ -227,6 +229,19 @@ static unsigned int imx_pcie_grp_offset(const
> > struct imx_pcie *imx_pcie)
> >
> >  static int imx95_pcie_init_phy(struct imx_pcie *imx_pcie)  {
> > +	/*
> > +	 * Workaround for ERR051624: The Controller Without Vaux Cannot
> > +	 * Exit L23 Ready Through Beacon or PERST# De-assertion
> > +	 *
> > +	 * When the auxiliary power is not available, the controller
> > +	 * cannot exit from L23 Ready with beacon or PERST# de-assertion
> > +	 * when main power is not removed.
> > +	 *
> > +	 * Workaround: Set SS_RW_REG_1[SYS_AUX_PWR_DET] to 1.
> > +	 */
> > +	regmap_update_bits(imx_pcie->iomuxc_gpr,
> IMX95_PCIE_SS_RW_REG_1,
> > +			IMX95_PCIE_SYS_AUX_PWR_DET,
> IMX95_PCIE_SYS_AUX_PWR_DET);
> 
> regmap_set_bits()
> 
> Frank
> > +
> >  	regmap_update_bits(imx_pcie->iomuxc_gpr,
> >  			IMX95_PCIE_SS_RW_REG_0,
> >  			IMX95_PCIE_PHY_CR_PARA_SEL,
> > --
> > 2.37.1
> >