linux-kernel - Re: [PATCH] mctp: Fix incorrect tx flow invalidation condition in mctp-i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b24e0c05bc9ae6eb102d71119bc3dd917a7f7c6d.camel@codeconstruct.com.au>
Date: Tue, 25 Mar 2025 16:30:00 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Daniel Hsu <d486250@...il.com>
Cc: matt@...econstruct.com.au, andrew+netdev@...n.ch, davem@...emloft.net, 
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
 netdev@...r.kernel.org,  linux-kernel@...r.kernel.org, Daniel Hsu
 <Daniel-Hsu@...ntatw.com>
Subject: Re: [PATCH] mctp: Fix incorrect tx flow invalidation condition in
 mctp-i2c

Hi Daniel,

> Previously, the condition for invalidating the tx flow in
> mctp_i2c_invalidate_tx_flow() checked if `rc` was nonzero.
> However, this could incorrectly trigger the invalidation
> even when `rc > 0` was returned as a success status.

Yes, and we should be seeing rc > 0 in normal behaviour...

> This patch updates the condition to explicitly check for `rc < 0`,
> ensuring that only error cases trigger the invalidation.

Looks good to me. I'll do some testing in my environment here, but in
the meantime:

Reviewed-by: Jeremy Kerr <jk@...econstruct.com.au>

I figure you'll want to target the net (not net-next) tree, in which
case you'll probably need this:

Fixes: 338a93cf4a18 ("net: mctp-i2c: invalidate flows immediately on TX errors")

Thanks for the contribution.

Cheers,


Jeremy