linux-kernel - Re: [PATCH v3 01/20] tools/x86/kcpuid: Fix error handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z-JvhGRhCg6Jimay@gmail.com>
Date: Tue, 25 Mar 2025 09:55:32 +0100
From: Ingo Molnar <mingo@...nel.org>
To: "Ahmed S. Darwish" <darwi@...utronix.de>
Cc: Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Andrew Cooper <andrew.cooper3@...rix.com>,
	"H. Peter Anvin" <hpa@...or.com>,
	John Ogness <john.ogness@...utronix.de>, x86@...nel.org,
	x86-cpuid@...ts.linux.dev, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 01/20] tools/x86/kcpuid: Fix error handling


* Ahmed S. Darwish <darwi@...utronix.de> wrote:

>  static void usage(void)
>  {
> -	printf("kcpuid [-abdfhr] [-l leaf] [-s subleaf]\n"
> -		"\t-a|--all             Show both bit flags and complex bit fields info\n"
> -		"\t-b|--bitflags        Show boolean flags only\n"
> -		"\t-d|--detail          Show details of the flag/fields (default)\n"
> -		"\t-f|--flags           Specify the cpuid csv file\n"
> -		"\t-h|--help            Show usage info\n"
> -		"\t-l|--leaf=index      Specify the leaf you want to check\n"
> -		"\t-r|--raw             Show raw cpuid data\n"
> -		"\t-s|--subleaf=sub     Specify the subleaf you want to check\n"
> +	warnx("kcpuid [-abdfhr] [-l leaf] [-s subleaf]\n"
> +	      "\t-a|--all             Show both bit flags and complex bit fields info\n"
> +	      "\t-b|--bitflags        Show boolean flags only\n"
> +	      "\t-d|--detail          Show details of the flag/fields (default)\n"
> +	      "\t-f|--flags           Specify the cpuid csv file\n"
> +	      "\t-h|--help            Show usage info\n"
> +	      "\t-l|--leaf=index      Specify the leaf you want to check\n"
> +	      "\t-r|--raw             Show raw cpuid data\n"
> +	      "\t-s|--subleaf=sub     Specify the subleaf you want to check"

Here you missed a few cases of:

 s/csv/CSV
 s/cpuid/CPUID

I fixed this all up in the patches & commits, no need to resend.

Thanks,

	Ingo