linux-kernel - Re: [v6] dma-engine: sun4i: Simplify error handling in probe()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7afcbbee-6261-4b2f-be14-a3076746d53c@prolan.hu>
Date: Tue, 25 Mar 2025 09:58:57 +0100
From: Csókás Bence <csokas.bence@...lan.hu>
To: Markus Elfring <Markus.Elfring@....de>, <dmaengine@...r.kernel.org>,
	<linux-sunxi@...ts.linux.dev>, <linux-arm-kernel@...ts.infradead.org>
CC: LKML <linux-kernel@...r.kernel.org>, Chen-Yu Tsai <wens@...nel.org>,
	Chen-Yu Tsai <wens@...e.org>, Christophe Jaillet
	<christophe.jaillet@...adoo.fr>, Jernej Skrabec <jernej.skrabec@...il.com>,
	Samuel Holland <samuel@...lland.org>, Vinod Koul <vkoul@...nel.org>
Subject: Re: [v6] dma-engine: sun4i: Simplify error handling in probe()

Hi,

On 2025. 03. 25. 9:47, Markus Elfring wrote:
> Implementation details are probably worth for another look.

What don't you like in the implementation? Let's discuss that then.

>> On 2025. 03. 24. 18:20, Bence Csókás wrote:
>>> Clean up error handling by using devm functions and dev_err_probe(). This
>>> should make it easier to add new code, as we can eliminate the "goto
>>> ladder" in sun4i_dma_probe().
> Please distinguish better between information from the “changelog”
> and items in a message subject.

What do you mean? The email body will be the commit message.

> Regards,
> Markus

Bence