linux-kernel - Re: [PATCH] ufs: qcom: Add quirks for Samsung UFS devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c0691392-1523-4863-a722-d4f4640e4e28@acm.org>
Date: Tue, 25 Mar 2025 07:42:53 -0400
From: Bart Van Assche <bvanassche@....org>
To: Manish Pandey <quic_mapa@...cinc.com>,
 Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
 "James E.J. Bottomley" <James.Bottomley@...senPartnership.com>,
 "Martin K. Petersen" <martin.petersen@...cle.com>
Cc: linux-arm-msm@...r.kernel.org, linux-scsi@...r.kernel.org,
 linux-kernel@...r.kernel.org, quic_nitirawa@...cinc.com,
 quic_bhaskarv@...cinc.com, quic_rampraka@...cinc.com, quic_cang@...cinc.com,
 quic_nguyenb@...cinc.com
Subject: Re: [PATCH] ufs: qcom: Add quirks for Samsung UFS devices

On 3/25/25 4:38 AM, Manish Pandey wrote:
> Introduce quirks for Samsung UFS devices to override PA hibern8 time,
> PA TX HSG1 sync length, and TX_HS_EQUALIZER for the Qualcomm UFS Host
> controller. These adjustments are essential to maintain the proper
> functionality of Samsung UFS devices for Qualcomm UFS Host controller.

Which of these quirks are required for all host controllers and which of
these quirks are only required for Qualcomm host controllers?

> +	equalizer_val = (gear == 5) ? DEEMPHASIS_3_5_dB : NO_DEEMPHASIS;

I think that the parenthesis can be removed from the above statement
without reducing readability of the code.

Thanks,

Bart.