linux-kernel - Re: [PATCH 2/3] dt-bindings: spi: Add DT schema for Tegra SPIDEV controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4zic633abvwj377kfqem42zmc2yruflbwfmmqrpvjjgr6jae6h@jthoycb3vzzz>
Date: Tue, 25 Mar 2025 13:45:26 +0100
From: Thierry Reding <thierry.reding@...il.com>
To: Mark Brown <broonie@...nel.org>
Cc: Jon Hunter <jonathanh@...dia.com>, Vishwaroop A <va@...dia.com>, 
	krzk+dt@...nel.org, robh@...nel.org, conor+dt@...nel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-tegra@...r.kernel.org, linux-spi@...r.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: spi: Add DT schema for Tegra SPIDEV
 controller

On Tue, Mar 25, 2025 at 12:10:19PM +0000, Mark Brown wrote:
> On Tue, Mar 25, 2025 at 10:36:29AM +0000, Jon Hunter wrote:
> > On 27/11/2024 17:31, Mark Brown wrote:
> 
> > > You can put 'spidev' in as the compatible and get the warning, we don't
> > > require specific compatibles if the Linux device ID is good enough.  If
> > > you genuinely just have bare wires you're probably able to cope with the
> > > warning.  If something is actually connected you should use the
> > > compatible for whatever that is, if spidev makes sense for it then
> > > that'd be OK to add to spidev.
> 
> > We finally got back to this. Looks like just having 'spidev' as the
> > compatible does not work. Apparently, it use to work and yes you would get
> > the warning, but that no longer seems to be the case. I see a few others
> > have been doing similar things and hacking their device-trees in different
> > ways [0].
> 
> Huh, OK.  I don't recall any deliberate SPI change for that.

People in the discussion that Jon linked to indicated that it was this
patch that caused the "regression":

commit 6840615f85f6046039ebc4989870ddb12892b7fc
Author: Mark Brown <broonie@...nel.org>
Date:   Thu Sep 23 18:00:23 2021 +0100
    spi: spidev: Add SPI ID table
    
    Currently autoloading for SPI devices does not use the DT ID table, it uses
    SPI modalises. Supporting OF modalises is going to be difficult if not
    impractical, an attempt was made but has been reverted, so ensure that
    module autoloading works for this driver by adding an id_table listing the
    SPI IDs for everything.
    
    Fixes: 96c8395e2166 ("spi: Revert modalias changes")
    Signed-off-by: Mark Brown <broonie@...nel.org>
    Link: https://lore.kernel.org/r/20210923170023.1683-1-broonie@kernel.org
    Signed-off-by: Mark Brown <broonie@...nel.org>

If you say that the regression wasn't deliberate, maybe we should look
at fixing this so that people don't have to work around stuff?

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)