linux-kernel - Re: [PATCH v4 01/11] scripts: generate_rust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <E0ED9858-7ABC-4461-BDB8-38D59AD3AF8B@collabora.com>
Date: Tue, 25 Mar 2025 10:08:42 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <benno.lossin@...ton.me>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Trevor Gross <tmgross@...ch.edu>,
 Danilo Krummrich <dakr@...nel.org>,
 Boris-Chengbiao Zhou <bobo1239@....de>,
 Kees Cook <kees@...nel.org>,
 Fiona Behrens <me@...enk.dev>,
 rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 Lukas Wirth <lukas.wirth@...rous-systems.com>
Subject: Re: [PATCH v4 01/11] scripts: generate_rust_analyzer.py: add missing
 whitespace



> On 22 Mar 2025, at 10:23, Tamir Duberstein <tamird@...il.com> wrote:
> 
> Add a space before the `/` operator for consistency with surrounding
> code and code formatting tools. Add a second newline between top-level
> items in accordance with PEP 8[1]:
> 
>> Surround top-level function and class definitions with two blank
> lines.
> 
> This change was made by a code formatting tool.
> 
> Link: https://peps.python.org/pep-0008/ [1]
> Reviewed-by: Fiona Behrens <me@...enk.dev>
> Signed-off-by: Tamir Duberstein <tamird@...il.com>
> ---
> scripts/generate_rust_analyzer.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/scripts/generate_rust_analyzer.py b/scripts/generate_rust_analyzer.py
> index a0e5a0aef444..fc1788764b31 100755
> --- a/scripts/generate_rust_analyzer.py
> +++ b/scripts/generate_rust_analyzer.py
> @@ -118,7 +118,7 @@ def generate_crates(srctree, objtree, sysroot_src, external_src, cfgs):
>     ):
>         append_crate(
>             display_name,
> -            srctree / "rust"/ display_name / "lib.rs",
> +            srctree / "rust" / display_name / "lib.rs",
>             deps,
>             cfg=cfg,
>         )
> @@ -193,5 +193,6 @@ def main():
> 
>     json.dump(rust_project, sys.stdout, sort_keys=True, indent=4)
> 
> +
> if __name__ == "__main__":
>     main()
> 
> -- 
> 2.48.1
> 
> 

Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>