linux-kernel - Re: [PATCH] nfs: add a refcount tracker for struct net as held by the nfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b777dcb43f68497d53bfc1038dfa01e29122d32a.camel@kernel.org>
Date: Tue, 25 Mar 2025 09:16:43 -0400
From: Jeff Layton <jlayton@...nel.org>
To: Trond Myklebust <trondmy@...nel.org>, Anna Schumaker <anna@...nel.org>
Cc: linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org, Eric Dumazet
	 <edumazet@...gle.com>
Subject: Re: [PATCH] nfs: add a refcount tracker for struct net as held by
 the nfs_client

On Tue, 2025-03-25 at 07:44 -0400, Jeff Layton wrote:
> Eric added refcount trackers to several long-held netns references in
> the sunrpc layer in 2022. Add a tracker to the netns reference held by
> the nfs_client as well.
> 
> Cc: Eric Dumazet <edumazet@...gle.com>
> Signed-off-by: Jeff Layton <jlayton@...nel.org>
> ---
>  fs/nfs/client.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/nfs/client.c b/fs/nfs/client.c
> index 3b0918ade53cd331d76baaa86fd2adec5d945b78..2ce58f2d6bf50924c38962ddedb7f0ca68752a8a 100644
> --- a/fs/nfs/client.c
> +++ b/fs/nfs/client.c
> @@ -180,7 +180,7 @@ struct nfs_client *nfs_alloc_client(const struct nfs_client_initdata *cl_init)
>  	clp->cl_proto = cl_init->proto;
>  	clp->cl_nconnect = cl_init->nconnect;
>  	clp->cl_max_connect = cl_init->max_connect ? cl_init->max_connect : 1;
> -	clp->cl_net = get_net(cl_init->net);
> +	clp->cl_net = get_net_track(cl_init->net, &clp->cl_ns_tracker, GFP_KERNEL);
>  
>  #if IS_ENABLED(CONFIG_NFS_LOCALIO)
>  	seqlock_init(&clp->cl_boot_lock);
> @@ -250,7 +250,7 @@ void nfs_free_client(struct nfs_client *clp)
>  	if (!IS_ERR(clp->cl_rpcclient))
>  		rpc_shutdown_client(clp->cl_rpcclient);
>  
> -	put_net(clp->cl_net);
> +	put_net_track(clp->cl_net, &clp->cl_ns_track);
>  	put_nfs_version(clp->cl_nfs_mod);
>  	kfree(clp->cl_hostname);
>  	kfree(clp->cl_acceptor);
> 
> ---
> base-commit: 38fec10eb60d687e30c8c6b5420d86e8149f7557
> change-id: 20250325-nfs-net-nef-fc2709b4efda
> 
> Best regards,

Please disregard this patch. This is an earlier version of the one I
_actually_ tested. I'll send a v2 when I get back from LSF.
-- 
Jeff Layton <jlayton@...nel.org>