linux-kernel - Re: [PATCH] staging: rtl8723bs: simplify if-else block by removing unnecessary braces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36d38aa1-39f7-ba14-633f-d3411a863a83@inria.fr>
Date: Tue, 25 Mar 2025 14:56:09 +0100 (CET)
From: Julia Lawall <julia.lawall@...ia.fr>
To: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>
cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, outreachy@...ts.linux.dev, 
    linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: simplify if-else block by removing
 unnecessary braces



On Tue, 25 Mar 2025, Abraham Samuel Adekunle wrote:

> The if-else block contained braces around single statements, which are
> unnecessary according to the Linux kernel coding style.
>
> Remove the redundant braces to improve code readability and maintain
> consistency with the rest of the codebase.
>
> Reported by checkpatch:
>
> WARNING: braces {} are not necessary for any arm of this statement
>
> Signed-off-by: Abraham Samuel Adekunle <abrahamadekunle50@...il.com>

Reviewed-by: Julia Lawall <julia.lawall@...ia.fr>

> ---
>  drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> index 0ed420f3d096..53d4c113b19c 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c
> @@ -988,11 +988,10 @@ void rtw_macaddr_cfg(struct device *dev, u8 *mac_addr)
>  	if (is_broadcast_ether_addr(mac) || is_zero_ether_addr(mac)) {
>  		addr = of_get_property(np, "local-mac-address", &len);
>
> -		if (addr && len == ETH_ALEN) {
> +		if (addr && len == ETH_ALEN)
>  			ether_addr_copy(mac_addr, addr);
> -		} else {
> +		else
>  			eth_random_addr(mac_addr);
> -		}
>  	}
>  }
>
> --
> 2.34.1
>
>