linux-kernel - Re: [PATCH v2 -next] RDMA/usnic: Fix passing zero to PTR_ERR in usnic_ib_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z+K103IYCOwa/pwg@ziepe.ca>
Date: Tue, 25 Mar 2025 10:55:31 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: Yue Haibing <yuehaibing@...wei.com>
Cc: benve@...co.com, neescoba@...co.com, leon@...nel.org,
	liyuyu6@...wei.com, roland@...estorage.com, umalhi@...co.com,
	linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org,
	yanjun.zhu@...ux.dev
Subject: Re: [PATCH v2 -next] RDMA/usnic: Fix passing zero to PTR_ERR in
 usnic_ib_pci_probe()

On Mon, Mar 24, 2025 at 08:31:32PM +0800, Yue Haibing wrote:
> drivers/infiniband/hw/usnic/usnic_ib_main.c:590
>  usnic_ib_pci_probe() warn: passing zero to 'PTR_ERR'
> 
> Make usnic_ib_device_add() return NULL on fail path, also remove
> useless NULL check for usnic_ib_discover_pf()
> 
> Fixes: e3cf00d0a87f ("IB/usnic: Add Cisco VIC low-level hardware driver")
> Signed-off-by: Yue Haibing <yuehaibing@...wei.com>
> Reviewed-by: Zhu Yanjun <yanjun.zhu@...ux.dev>
> ---
> v2: remove useless null check for usnic_ib_discover_pf
> ---
>  drivers/infiniband/hw/usnic/usnic_ib_main.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@...dia.com>

Jason