linux-kernel - Re: [PATCH net-next 6/9] net: ethernet: ti: cpsw_ale: add cpsw_ale_policer_set/clr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250325072244.58340f12@kernel.org>
Date: Tue, 25 Mar 2025 07:22:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Roger Quadros <rogerq@...nel.org>
Cc: Siddharth Vadapalli <s-vadapalli@...com>, Andrew Lunn
 <andrew+netdev@...n.ch>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Russell
 King <linux@...linux.org.uk>, danishanwar@...com, srk@...com,
 linux-omap@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 6/9] net: ethernet: ti: cpsw_ale: add
 cpsw_ale_policer_set/clr_entry()

On Wed, 19 Mar 2025 15:38:32 +0200 Roger Quadros wrote:
> +		ale_idx = cpsw_ale_add_ucast(ale, cfg->src_addr, HOST_PORT_NUM, ale_flags, 0);
> +		if (ale_idx < 0)
> +			return -ENOENT;
> +
> +		/* update policer entry */
> +		regmap_field_write(ale->fields[POL_SRC_INDEX], ale_idx);
> +		regmap_field_write(ale->fields[POL_SRC_MEN], 1);
> +	}
> +
> +	if (cfg->match_flags & CPSW_ALE_POLICER_MATCH_MACDST) {
> +		ale_idx = cpsw_ale_add_ucast(ale, cfg->dst_addr, HOST_PORT_NUM, ale_flags, 0);

Try to wrap at 80 chars if it doesn't impact code readability.

./scripts/checkpatch.pl --max-line-length=80 --strict  ...