| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CA+V-a8thYZhYS_5FUQxbTmr7O+G4UZMhRQzRUwBr9V9GD7nyWQ@mail.gmail.com>
Date: Tue, 25 Mar 2025 14:39:45 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Florian Fainelli <florian.fainelli@...adcom.com>,
Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Jim Quinlan <jim2101024@...il.com>,
Nicolas Saenz Julienne <nsaenz@...nel.org>, Lorenzo Pieralisi <lpieralisi@...nel.org>,
Krzysztof Wilczyński <kw@...ux.com>,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>, Rob Herring <robh@...nel.org>,
Bjorn Helgaas <bhelgaas@...gle.com>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, Srikanth Thokala <srikanth.thokala@...el.com>,
Daire McNamara <daire.mcnamara@...rochip.com>, Marek Vasut <marek.vasut+renesas@...il.com>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>, Paul Walmsley <paul.walmsley@...ive.com>,
Greentime Hu <greentime.hu@...ive.com>, Samuel Holland <samuel.holland@...ive.com>,
Bharat Kumar Gogada <bharat.kumar.gogada@....com>, Michal Simek <michal.simek@....com>,
Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>,
Tom Joseph <tjoseph@...ence.com>, Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@...el.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
linux-rpi-kernel@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
linux-riscv@...ts.infradead.org
Subject: Re: [PATCH 1/2] dt-bindings: PCI: Correct indentation and style in
DTS example
On Mon, Mar 24, 2025 at 12:53 PM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> DTS example in the bindings should be indented with 2- or 4-spaces and
> aligned with opening '- |', so correct any differences like 3-spaces or
> mixtures 2- and 4-spaces in one binding.
>
> No functional changes here, but saves some comments during reviews of
> new patches built on existing code.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---
> .../bindings/pci/brcm,stb-pcie.yaml | 81 +++++++------
> .../bindings/pci/cdns,cdns-pcie-ep.yaml | 16 +--
> .../bindings/pci/intel,keembay-pcie-ep.yaml | 26 ++--
> .../bindings/pci/intel,keembay-pcie.yaml | 38 +++---
> .../bindings/pci/microchip,pcie-host.yaml | 54 ++++-----
> .../devicetree/bindings/pci/rcar-pci-ep.yaml | 34 +++---
For rcar-pci-ep.yaml,
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Cheers,
Prabhakar
> .../bindings/pci/rcar-pci-host.yaml | 46 +++----
> .../bindings/pci/xilinx-versal-cpm.yaml | 112 +++++++++---------
> 8 files changed, 202 insertions(+), 205 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> index 29f0e1eb5096..c4f9674e8695 100644
> --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml
> @@ -186,49 +186,48 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
>
> scb {
> - #address-cells = <2>;
> - #size-cells = <1>;
> - pcie0: pcie@...00000 {
> - compatible = "brcm,bcm2711-pcie";
> - reg = <0x0 0x7d500000 0x9310>;
> - device_type = "pci";
> - #address-cells = <3>;
> - #size-cells = <2>;
> - #interrupt-cells = <1>;
> - interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "pcie", "msi";
> - interrupt-map-mask = <0x0 0x0 0x0 0x7>;
> - interrupt-map = <0 0 0 1 &gicv2 GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH
> - 0 0 0 2 &gicv2 GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH
> - 0 0 0 3 &gicv2 GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH
> - 0 0 0 4 &gicv2 GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;
> + #address-cells = <2>;
> + #size-cells = <1>;
> + pcie0: pcie@...00000 {
> + compatible = "brcm,bcm2711-pcie";
> + reg = <0x0 0x7d500000 0x9310>;
> + device_type = "pci";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + #interrupt-cells = <1>;
> + interrupts = <GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "pcie", "msi";
> + interrupt-map-mask = <0x0 0x0 0x0 0x7>;
> + interrupt-map = <0 0 0 1 &gicv2 GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH
> + 0 0 0 2 &gicv2 GIC_SPI 144 IRQ_TYPE_LEVEL_HIGH
> + 0 0 0 3 &gicv2 GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH
> + 0 0 0 4 &gicv2 GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>;
>
> - msi-parent = <&pcie0>;
> - msi-controller;
> - ranges = <0x02000000 0x0 0xf8000000 0x6 0x00000000 0x0 0x04000000>;
> - dma-ranges = <0x42000000 0x1 0x00000000 0x0 0x40000000 0x0 0x80000000>,
> - <0x42000000 0x1 0x80000000 0x3 0x00000000 0x0 0x80000000>;
> - brcm,enable-ssc;
> - brcm,scb-sizes = <0x0000000080000000 0x0000000080000000>;
> + msi-parent = <&pcie0>;
> + msi-controller;
> + ranges = <0x02000000 0x0 0xf8000000 0x6 0x00000000 0x0 0x04000000>;
> + dma-ranges = <0x42000000 0x1 0x00000000 0x0 0x40000000 0x0 0x80000000>,
> + <0x42000000 0x1 0x80000000 0x3 0x00000000 0x0 0x80000000>;
> + brcm,enable-ssc;
> + brcm,scb-sizes = <0x0000000080000000 0x0000000080000000>;
>
> - /* PCIe bridge, Root Port */
> - pci@0,0 {
> - #address-cells = <3>;
> - #size-cells = <2>;
> - reg = <0x0 0x0 0x0 0x0 0x0>;
> - compatible = "pciclass,0604";
> - device_type = "pci";
> - vpcie3v3-supply = <&vreg7>;
> - ranges;
> + /* PCIe bridge, Root Port */
> + pci@0,0 {
> + #address-cells = <3>;
> + #size-cells = <2>;
> + reg = <0x0 0x0 0x0 0x0 0x0>;
> + compatible = "pciclass,0604";
> + device_type = "pci";
> + vpcie3v3-supply = <&vreg7>;
> + ranges;
>
> - /* PCIe endpoint */
> - pci-ep@0,0 {
> - assigned-addresses =
> - <0x82010000 0x0 0xf8000000 0x6 0x00000000 0x0 0x2000>;
> - reg = <0x0 0x0 0x0 0x0 0x0>;
> - compatible = "pci14e4,1688";
> - };
> - };
> + /* PCIe endpoint */
> + pci-ep@0,0 {
> + assigned-addresses = <0x82010000 0x0 0xf8000000 0x6 0x00000000 0x0 0x2000>;
> + reg = <0x0 0x0 0x0 0x0 0x0>;
> + compatible = "pci14e4,1688";
> + };
> };
> + };
> };
> diff --git a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> index 98651ab22103..8735293962ee 100644
> --- a/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/cdns,cdns-pcie-ep.yaml
> @@ -37,14 +37,14 @@ examples:
> #size-cells = <2>;
>
> pcie-ep@...00000 {
> - compatible = "cdns,cdns-pcie-ep";
> - reg = <0x0 0xfc000000 0x0 0x01000000>,
> - <0x0 0x80000000 0x0 0x40000000>;
> - reg-names = "reg", "mem";
> - cdns,max-outbound-regions = <16>;
> - max-functions = /bits/ 8 <8>;
> - phys = <&pcie_phy0>;
> - phy-names = "pcie-phy";
> + compatible = "cdns,cdns-pcie-ep";
> + reg = <0x0 0xfc000000 0x0 0x01000000>,
> + <0x0 0x80000000 0x0 0x40000000>;
> + reg-names = "reg", "mem";
> + cdns,max-outbound-regions = <16>;
> + max-functions = /bits/ 8 <8>;
> + phys = <&pcie_phy0>;
> + phy-names = "pcie-phy";
> };
> };
> ...
> diff --git a/Documentation/devicetree/bindings/pci/intel,keembay-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/intel,keembay-pcie-ep.yaml
> index 730e63fd7669..b19f61ae72fb 100644
> --- a/Documentation/devicetree/bindings/pci/intel,keembay-pcie-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/intel,keembay-pcie-ep.yaml
> @@ -53,17 +53,17 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/interrupt-controller/irq.h>
> pcie-ep@...00000 {
> - compatible = "intel,keembay-pcie-ep";
> - reg = <0x37000000 0x00001000>,
> - <0x37100000 0x00001000>,
> - <0x37300000 0x00001000>,
> - <0x36000000 0x01000000>,
> - <0x37800000 0x00000200>;
> - reg-names = "dbi", "dbi2", "atu", "addr_space", "apb";
> - interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 108 IRQ_TYPE_EDGE_RISING>,
> - <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "pcie", "pcie_ev", "pcie_err", "pcie_mem_access";
> - num-lanes = <2>;
> + compatible = "intel,keembay-pcie-ep";
> + reg = <0x37000000 0x00001000>,
> + <0x37100000 0x00001000>,
> + <0x37300000 0x00001000>,
> + <0x36000000 0x01000000>,
> + <0x37800000 0x00000200>;
> + reg-names = "dbi", "dbi2", "atu", "addr_space", "apb";
> + interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 108 IRQ_TYPE_EDGE_RISING>,
> + <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "pcie", "pcie_ev", "pcie_err", "pcie_mem_access";
> + num-lanes = <2>;
> };
> diff --git a/Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml b/Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml
> index 1fd557504b10..dd71e3d6bf94 100644
> --- a/Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/intel,keembay-pcie.yaml
> @@ -75,23 +75,23 @@ examples:
> #define KEEM_BAY_A53_PCIE
> #define KEEM_BAY_A53_AUX_PCIE
> pcie@...00000 {
> - compatible = "intel,keembay-pcie";
> - reg = <0x37000000 0x00001000>,
> - <0x37300000 0x00001000>,
> - <0x36e00000 0x00200000>,
> - <0x37800000 0x00000200>;
> - reg-names = "dbi", "atu", "config", "apb";
> - #address-cells = <3>;
> - #size-cells = <2>;
> - device_type = "pci";
> - ranges = <0x02000000 0 0x36000000 0x36000000 0 0x00e00000>;
> - interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
> - interrupt-names = "pcie", "pcie_ev", "pcie_err";
> - clocks = <&scmi_clk KEEM_BAY_A53_PCIE>,
> - <&scmi_clk KEEM_BAY_A53_AUX_PCIE>;
> - clock-names = "master", "aux";
> - reset-gpios = <&pca2 9 GPIO_ACTIVE_LOW>;
> - num-lanes = <2>;
> + compatible = "intel,keembay-pcie";
> + reg = <0x37000000 0x00001000>,
> + <0x37300000 0x00001000>,
> + <0x36e00000 0x00200000>,
> + <0x37800000 0x00000200>;
> + reg-names = "dbi", "atu", "config", "apb";
> + #address-cells = <3>;
> + #size-cells = <2>;
> + device_type = "pci";
> + ranges = <0x02000000 0 0x36000000 0x36000000 0 0x00e00000>;
> + interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "pcie", "pcie_ev", "pcie_err";
> + clocks = <&scmi_clk KEEM_BAY_A53_PCIE>,
> + <&scmi_clk KEEM_BAY_A53_AUX_PCIE>;
> + clock-names = "master", "aux";
> + reset-gpios = <&pca2 9 GPIO_ACTIVE_LOW>;
> + num-lanes = <2>;
> };
> diff --git a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
> index 103574d18dbc..1aadfdee868f 100644
> --- a/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/microchip,pcie-host.yaml
> @@ -65,33 +65,33 @@ unevaluatedProperties: false
> examples:
> - |
> soc {
> - #address-cells = <2>;
> + #address-cells = <2>;
> + #size-cells = <2>;
> + pcie0: pcie@...0000000 {
> + compatible = "microchip,pcie-host-1.0";
> + reg = <0x0 0x70000000 0x0 0x08000000>,
> + <0x0 0x43008000 0x0 0x00002000>,
> + <0x0 0x4300a000 0x0 0x00002000>;
> + reg-names = "cfg", "bridge", "ctrl";
> + device_type = "pci";
> + #address-cells = <3>;
> #size-cells = <2>;
> - pcie0: pcie@...0000000 {
> - compatible = "microchip,pcie-host-1.0";
> - reg = <0x0 0x70000000 0x0 0x08000000>,
> - <0x0 0x43008000 0x0 0x00002000>,
> - <0x0 0x4300a000 0x0 0x00002000>;
> - reg-names = "cfg", "bridge", "ctrl";
> - device_type = "pci";
> - #address-cells = <3>;
> - #size-cells = <2>;
> - #interrupt-cells = <1>;
> - interrupts = <119>;
> - interrupt-map-mask = <0x0 0x0 0x0 0x7>;
> - interrupt-map = <0 0 0 1 &pcie_intc0 0>,
> - <0 0 0 2 &pcie_intc0 1>,
> - <0 0 0 3 &pcie_intc0 2>,
> - <0 0 0 4 &pcie_intc0 3>;
> - interrupt-parent = <&plic0>;
> - msi-parent = <&pcie0>;
> - msi-controller;
> - bus-range = <0x00 0x7f>;
> - ranges = <0x03000000 0x0 0x78000000 0x0 0x78000000 0x0 0x04000000>;
> - pcie_intc0: interrupt-controller {
> - #address-cells = <0>;
> - #interrupt-cells = <1>;
> - interrupt-controller;
> - };
> + #interrupt-cells = <1>;
> + interrupts = <119>;
> + interrupt-map-mask = <0x0 0x0 0x0 0x7>;
> + interrupt-map = <0 0 0 1 &pcie_intc0 0>,
> + <0 0 0 2 &pcie_intc0 1>,
> + <0 0 0 3 &pcie_intc0 2>,
> + <0 0 0 4 &pcie_intc0 3>;
> + interrupt-parent = <&plic0>;
> + msi-parent = <&pcie0>;
> + msi-controller;
> + bus-range = <0x00 0x7f>;
> + ranges = <0x03000000 0x0 0x78000000 0x0 0x78000000 0x0 0x04000000>;
> + pcie_intc0: interrupt-controller {
> + #address-cells = <0>;
> + #interrupt-cells = <1>;
> + interrupt-controller;
> };
> + };
> };
> diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> index 32a3b7665ff5..6b91581c30ae 100644
> --- a/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> +++ b/Documentation/devicetree/bindings/pci/rcar-pci-ep.yaml
> @@ -73,21 +73,21 @@ examples:
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/power/r8a774c0-sysc.h>
>
> - pcie0_ep: pcie-ep@...00000 {
> - compatible = "renesas,r8a774c0-pcie-ep",
> - "renesas,rcar-gen3-pcie-ep";
> - reg = <0xfe000000 0x80000>,
> - <0xfe100000 0x100000>,
> - <0xfe200000 0x200000>,
> - <0x30000000 0x8000000>,
> - <0x38000000 0x8000000>;
> - reg-names = "apb-base", "memory0", "memory1", "memory2", "memory3";
> - interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
> - resets = <&cpg 319>;
> - power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
> - clocks = <&cpg CPG_MOD 319>;
> - clock-names = "pcie";
> - max-functions = /bits/ 8 <1>;
> + pcie0_ep: pcie-ep@...00000 {
> + compatible = "renesas,r8a774c0-pcie-ep",
> + "renesas,rcar-gen3-pcie-ep";
> + reg = <0xfe000000 0x80000>,
> + <0xfe100000 0x100000>,
> + <0xfe200000 0x200000>,
> + <0x30000000 0x8000000>,
> + <0x38000000 0x8000000>;
> + reg-names = "apb-base", "memory0", "memory1", "memory2", "memory3";
> + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
> + resets = <&cpg 319>;
> + power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
> + clocks = <&cpg CPG_MOD 319>;
> + clock-names = "pcie";
> + max-functions = /bits/ 8 <1>;
> };
> diff --git a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
> index 666f013e3af8..7896576920aa 100644
> --- a/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
> +++ b/Documentation/devicetree/bindings/pci/rcar-pci-host.yaml
> @@ -113,27 +113,27 @@ examples:
> pcie: pcie@...00000 {
> compatible = "renesas,pcie-r8a7791", "renesas,pcie-rcar-gen2";
> reg = <0 0xfe000000 0 0x80000>;
> - #address-cells = <3>;
> - #size-cells = <2>;
> - bus-range = <0x00 0xff>;
> - device_type = "pci";
> - ranges = <0x01000000 0 0x00000000 0 0xfe100000 0 0x00100000>,
> - <0x02000000 0 0xfe200000 0 0xfe200000 0 0x00200000>,
> - <0x02000000 0 0x30000000 0 0x30000000 0 0x08000000>,
> - <0x42000000 0 0x38000000 0 0x38000000 0 0x08000000>;
> - dma-ranges = <0x42000000 0 0x40000000 0 0x40000000 0 0x40000000>,
> - <0x42000000 2 0x00000000 2 0x00000000 0 0x40000000>;
> - interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
> - <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
> - #interrupt-cells = <1>;
> - interrupt-map-mask = <0 0 0 0>;
> - interrupt-map = <0 0 0 0 &gic GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
> - clocks = <&cpg CPG_MOD 319>, <&pcie_bus_clk>;
> - clock-names = "pcie", "pcie_bus";
> - power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
> - resets = <&cpg 319>;
> - vpcie3v3-supply = <&pcie_3v3>;
> - vpcie12v-supply = <&pcie_12v>;
> - };
> + #address-cells = <3>;
> + #size-cells = <2>;
> + bus-range = <0x00 0xff>;
> + device_type = "pci";
> + ranges = <0x01000000 0 0x00000000 0 0xfe100000 0 0x00100000>,
> + <0x02000000 0 0xfe200000 0 0xfe200000 0 0x00200000>,
> + <0x02000000 0 0x30000000 0 0x30000000 0 0x08000000>,
> + <0x42000000 0 0x38000000 0 0x38000000 0 0x08000000>;
> + dma-ranges = <0x42000000 0 0x40000000 0 0x40000000 0 0x40000000>,
> + <0x42000000 2 0x00000000 2 0x00000000 0 0x40000000>;
> + interrupts = <GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 117 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 118 IRQ_TYPE_LEVEL_HIGH>;
> + #interrupt-cells = <1>;
> + interrupt-map-mask = <0 0 0 0>;
> + interrupt-map = <0 0 0 0 &gic GIC_SPI 116 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cpg CPG_MOD 319>, <&pcie_bus_clk>;
> + clock-names = "pcie", "pcie_bus";
> + power-domains = <&sysc R8A7791_PD_ALWAYS_ON>;
> + resets = <&cpg 319>;
> + vpcie3v3-supply = <&pcie_3v3>;
> + vpcie12v-supply = <&pcie_12v>;
> + };
> };
> diff --git a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> index d674a24c8ccc..9823456addea 100644
> --- a/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> +++ b/Documentation/devicetree/bindings/pci/xilinx-versal-cpm.yaml
> @@ -76,64 +76,62 @@ unevaluatedProperties: false
>
> examples:
> - |
> -
> versal {
> - #address-cells = <2>;
> - #size-cells = <2>;
> - cpm_pcie: pcie@...10000 {
> - compatible = "xlnx,versal-cpm-host-1.00";
> - device_type = "pci";
> - #address-cells = <3>;
> - #interrupt-cells = <1>;
> - #size-cells = <2>;
> - interrupts = <0 72 4>;
> - interrupt-parent = <&gic>;
> - interrupt-map-mask = <0 0 0 7>;
> - interrupt-map = <0 0 0 1 &pcie_intc_0 0>,
> - <0 0 0 2 &pcie_intc_0 1>,
> - <0 0 0 3 &pcie_intc_0 2>,
> - <0 0 0 4 &pcie_intc_0 3>;
> - bus-range = <0x00 0xff>;
> - ranges = <0x02000000 0x0 0xe0010000 0x0 0xe0010000 0x0 0x10000000>,
> - <0x43000000 0x80 0x00000000 0x80 0x00000000 0x0 0x80000000>;
> - msi-map = <0x0 &its_gic 0x0 0x10000>;
> - reg = <0x0 0xfca10000 0x0 0x1000>,
> - <0x6 0x00000000 0x0 0x10000000>;
> - reg-names = "cpm_slcr", "cfg";
> - pcie_intc_0: interrupt-controller {
> - #address-cells = <0>;
> - #interrupt-cells = <1>;
> - interrupt-controller;
> - };
> - };
> + #address-cells = <2>;
> + #size-cells = <2>;
> + pcie@...10000 {
> + compatible = "xlnx,versal-cpm-host-1.00";
> + device_type = "pci";
> + #address-cells = <3>;
> + #interrupt-cells = <1>;
> + #size-cells = <2>;
> + interrupts = <0 72 4>;
> + interrupt-parent = <&gic>;
> + interrupt-map-mask = <0 0 0 7>;
> + interrupt-map = <0 0 0 1 &pcie_intc_0 0>,
> + <0 0 0 2 &pcie_intc_0 1>,
> + <0 0 0 3 &pcie_intc_0 2>,
> + <0 0 0 4 &pcie_intc_0 3>;
> + bus-range = <0x00 0xff>;
> + ranges = <0x02000000 0x0 0xe0010000 0x0 0xe0010000 0x0 0x10000000>,
> + <0x43000000 0x80 0x00000000 0x80 0x00000000 0x0 0x80000000>;
> + msi-map = <0x0 &its_gic 0x0 0x10000>;
> + reg = <0x0 0xfca10000 0x0 0x1000>,
> + <0x6 0x00000000 0x0 0x10000000>;
> + reg-names = "cpm_slcr", "cfg";
> + pcie_intc_0: interrupt-controller {
> + #address-cells = <0>;
> + #interrupt-cells = <1>;
> + interrupt-controller;
> + };
> + };
>
> - cpm5_pcie: pcie@...d0000 {
> - compatible = "xlnx,versal-cpm5-host";
> - device_type = "pci";
> - #address-cells = <3>;
> - #interrupt-cells = <1>;
> - #size-cells = <2>;
> - interrupts = <0 72 4>;
> - interrupt-parent = <&gic>;
> - interrupt-map-mask = <0 0 0 7>;
> - interrupt-map = <0 0 0 1 &pcie_intc_1 0>,
> - <0 0 0 2 &pcie_intc_1 1>,
> - <0 0 0 3 &pcie_intc_1 2>,
> - <0 0 0 4 &pcie_intc_1 3>;
> - bus-range = <0x00 0xff>;
> - ranges = <0x02000000 0x0 0xe0000000 0x0 0xe0000000 0x0 0x10000000>,
> - <0x43000000 0x80 0x00000000 0x80 0x00000000 0x0 0x80000000>;
> - msi-map = <0x0 &its_gic 0x0 0x10000>;
> - reg = <0x00 0xfcdd0000 0x00 0x1000>,
> - <0x06 0x00000000 0x00 0x1000000>,
> - <0x00 0xfce20000 0x00 0x1000000>;
> - reg-names = "cpm_slcr", "cfg", "cpm_csr";
> -
> - pcie_intc_1: interrupt-controller {
> - #address-cells = <0>;
> - #interrupt-cells = <1>;
> - interrupt-controller;
> - };
> - };
> + pcie@...d0000 {
> + compatible = "xlnx,versal-cpm5-host";
> + device_type = "pci";
> + #address-cells = <3>;
> + #interrupt-cells = <1>;
> + #size-cells = <2>;
> + interrupts = <0 72 4>;
> + interrupt-parent = <&gic>;
> + interrupt-map-mask = <0 0 0 7>;
> + interrupt-map = <0 0 0 1 &pcie_intc_1 0>,
> + <0 0 0 2 &pcie_intc_1 1>,
> + <0 0 0 3 &pcie_intc_1 2>,
> + <0 0 0 4 &pcie_intc_1 3>;
> + bus-range = <0x00 0xff>;
> + ranges = <0x02000000 0x0 0xe0000000 0x0 0xe0000000 0x0 0x10000000>,
> + <0x43000000 0x80 0x00000000 0x80 0x00000000 0x0 0x80000000>;
> + msi-map = <0x0 &its_gic 0x0 0x10000>;
> + reg = <0x00 0xfcdd0000 0x00 0x1000>,
> + <0x06 0x00000000 0x00 0x1000000>,
> + <0x00 0xfce20000 0x00 0x1000000>;
> + reg-names = "cpm_slcr", "cfg", "cpm_csr";
>
> + pcie_intc_1: interrupt-controller {
> + #address-cells = <0>;
> + #interrupt-cells = <1>;
> + interrupt-controller;
> + };
> + };
> };
> --
> 2.43.0
>
>
Powered by blists - more mailing lists