linux-kernel - Re: [PATCH] bcachefs: replace deprecated strncpy() with strscpy()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <A4568396-D1E1-4D93-851B-FA9CF9804E10@gmail.com>
Date: Thu, 27 Mar 2025 00:36:25 +0800
From: Alan Huang <mmpgouride@...il.com>
To: Kent Overstreet <kent.overstreet@...ux.dev>
Cc: Bharadwaj Raju <bharadwaj.raju777@...il.com>,
 Roxana Nicolescu <nicolescu.roxana@...tonmail.com>,
 linux-bcachefs@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 skhan@...uxfoundation.org,
 linux-kernel-mentees@...ts.linux.dev
Subject: Re: [PATCH] bcachefs: replace deprecated strncpy() with strscpy()

On Mar 27, 2025, at 00:17, Kent Overstreet <kent.overstreet@...ux.dev> wrote:
> 
> On Wed, Mar 26, 2025 at 09:19:06PM +0530, Bharadwaj Raju wrote:
>> On Wed, Mar 26, 2025 at 8:22 PM Kent Overstreet
>> <kent.overstreet@...ux.dev> wrote:
>>> Or better, a new helper: when we're copying to a fixed size buffer we
>>> really want to zero out the rest of the buffer - we don't just want a
>>> single terminating nul.
>> 
>> I believe strscpy_pad does this?
>> 
>> https://docs.kernel.org/core-api/kernel-api.html#c.strscpy_pad
> 
> almost, we don't want the 'required nul termination'; that's a
> requirement at least for disk labels where we need to preserve existing
> behaviour

memcpy_and_pad :)