linux-kernel - Re: [PATCH] media: dt-bindings: Add OmniVision OV02C10

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1959f95-9ee1-4597-b6ec-fbedc8a872db@kernel.org>
Date: Wed, 26 Mar 2025 18:19:54 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>, robh@...nel.org,
 hdegoede@...hat.com, mchehab@...nel.org, krzk+dt@...nel.org,
 conor+dt@...nel.org, sakari.ailus@...ux.intel.com, hverkuil@...all.nl
Cc: linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, bod@...nel.org
Subject: Re: [PATCH] media: dt-bindings: Add OmniVision OV02C10

On 26/03/2025 18:09, Bryan O'Donoghue wrote:
> On 26/03/2025 15:40, Krzysztof Kozlowski wrote:
>> On 26/03/2025 16:01, Bryan O'Donoghue wrote:
>>> Add bindings for OVO2C10 a two megapixel 1080p RGB sensor.
>>>
>> You already sent this and got some review. What's more, it's exactly the
>> same as OV02E10, so just put it to that file.
>>
>> Best regards,
>> Krzysztof
> 
> They aren't exactly the same.
> 
> The i2c address of the sensors is different 0x10 for one and 0x36 the other.
> 
> Also different data-rates for each chip.


I meant bindings are exactly the same, unless I missed something.
Devices are similar enough as well.

> Seems simpler to me to have two separate files ?

Not really, more files to maintain, more trivialities to fix if we
decide to change something in all bindings (e.g. style).

Best regards,
Krzysztof