linux-kernel - Re: [PATCH v2] sched/rt: Fix race in push_rt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <801794EB-9075-4097-9355-76A042B62FB5@nutanix.com>
Date: Wed, 26 Mar 2025 17:57:23 +0000
From: Harshit Agarwal <harshit@...anix.com>
To: Phil Auld <pauld@...hat.com>
CC: Steven Rostedt <rostedt@...dmis.org>, Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann
	<dietmar.eggemann@....com>,
        Ben Segall <bsegall@...gle.com>, Mel Gorman
	<mgorman@...e.de>,
        Valentin Schneider <vschneid@...hat.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "stable@...r.kernel.org" <stable@...r.kernel.org>,
        Jon Kohler
	<jon@...anix.com>,
        Gauri Patwardhan <gauri.patwardhan@...anix.com>,
        Rahul
 Chunduru <rahul.chunduru@...anix.com>,
        Will Ton <william.ton@...anix.com>
Subject: Re: [PATCH v2] sched/rt: Fix race in push_rt_task



> On Mar 26, 2025, at 6:18 AM, Phil Auld <pauld@...hat.com> wrote:
>> 
> 
> We've got some cases that look to be hitting this as well.
> 
> I'm a little concerned about turning some runtime checks into
> BUG_ON()s but in this case I think we are really just going to
> trap out on !has_pushable_tasks() check first and if not, pick
> a different task and don't drop the lock so it should pass the
> BUG_ON()s and fail to match the original task.  So...
> 
> Reviewed-by: Phil Auld <pauld@...hat.com>
> 

Thanks Phil for your review. Just FYI this is the link to
v3 (latest version) of this change 
https://lore.kernel.org/lkml/20250225180553.167995-1-harshit@nutanix.com/
No change here in the code w.r.t v2. I had just updated the
commit message to add stable maintainers.

Regards,
Harshit