linux-kernel - Re: [PATCH v8 3/7] i2c: Add Nuvoton NCT6694 I2C support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOoeyxUwgxsLNN1i8vM6_NdR+ytesuVA1iE_TSO4CPbSa2sAnw@mail.gmail.com>
Date: Wed, 26 Mar 2025 10:46:17 +0800
From: Ming Yu <a0282524688@...il.com>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: tmyu0@...oton.com, lee@...nel.org, linus.walleij@...aro.org, brgl@...ev.pl, 
	mkl@...gutronix.de, mailhol.vincent@...adoo.fr, andrew+netdev@...n.ch, 
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, 
	wim@...ux-watchdog.org, linux@...ck-us.net, jdelvare@...e.com, 
	alexandre.belloni@...tlin.com, linux-kernel@...r.kernel.org, 
	linux-gpio@...r.kernel.org, linux-i2c@...r.kernel.org, 
	linux-can@...r.kernel.org, netdev@...r.kernel.org, 
	linux-watchdog@...r.kernel.org, linux-hwmon@...r.kernel.org, 
	linux-rtc@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v8 3/7] i2c: Add Nuvoton NCT6694 I2C support

Dear Andi,

Thank you for reviewing,

Andi Shyti <andi.shyti@...nel.org> 於 2025年3月20日 週四 上午7:58寫道：
>
...
> > +enum i2c_baudrate {
> > +     I2C_BR_25K = 0,
> > +     I2C_BR_50K,
> > +     I2C_BR_100K,
> > +     I2C_BR_200K,
> > +     I2C_BR_400K,
> > +     I2C_BR_800K,
> > +     I2C_BR_1M
> > +};
>
> do we need all these frequencies? I don't see them use anywhere.
>

Originally, I used module parameters to configure these I2C's baud
rate, Do you think this approach iis suitable?

> Besides, can you please use a proper prefix? I2C_BR_* prefix
> doesn't belong to this driver.
>

Okay, I will fix these macros in the next patch.


Best regards,
Ming