linux-kernel - Re: [PATCH] net: dsa: felix: check felix_cpu_port_for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3370aa96-a320-4b8e-b37b-b8100094d3c9@lunn.ch>
Date: Wed, 26 Mar 2025 19:37:59 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Vitaliy Shevtsov <v.shevtsov@...integration.ru>
Cc: Vladimir Oltean <vladimir.oltean@....com>,
	Claudiu Manoil <claudiu.manoil@....com>,
	Alexandre Belloni <alexandre.belloni@...tlin.com>,
	UNGLinuxDriver@...rochip.com,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	lvc-project@...uxtesting.org
Subject: Re: [PATCH] net: dsa: felix: check felix_cpu_port_for_conduit() for
 failure

On Wed, Mar 26, 2025 at 11:29:29PM +0500, Vitaliy Shevtsov wrote:
> On Wed, 26 Mar 2025 19:22:07 +0100, Andrew Lunn wrote:
> 
> > If i'm reading the code correctly you mean ocelot_bond_get_id()
> > returns -ENOENT?
> > 
> > If so, you should return the ENOENT, not replace it by EINVAL.
> > 
> > 	Andrew
> 
> Or maybe it's better to just return negative cpu value instead?

Yes, that is what i meant. The typical pattern is:

			int lag = ocelot_bond_get_id(ocelot, bond);
			if (lag < 0)
				return lag

	Andrew