linux-kernel - Re: [PATCH net-next v2 0/7] selftests/net: Mixed select()+polling mode for TCP-AO tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJwJo6YoGz1aPv5nkJJKa05mxF-Zhc+B4U6kRw95KSduLCApaw@mail.gmail.com>
Date: Wed, 26 Mar 2025 19:48:16 +0000
From: Dmitry Safonov <0x7f454c46@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Dmitry Safonov via B4 Relay <devnull+0x7f454c46.gmail.com@...nel.org>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>, 
	netdev@...r.kernel.org, linux-kselftest@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v2 0/7] selftests/net: Mixed select()+polling
 mode for TCP-AO tests

On Tue, 25 Mar 2025 at 13:15, Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Wed, 19 Mar 2025 03:13:33 +0000 Dmitry Safonov via B4 Relay wrote:
> > Should fix flaky tcp-ao/connect-deny-ipv6 test.
> > Begging pardon for the delay since the report and for sending it this
> > late in the release cycle.
>
> Better late than never, thanks a lot! :)

Thank you, Jakub!

I also noticed that recently, self-connect-ipv6 became slightly flaky:
https://netdev.bots.linux.dev/flakes.html?br-cnt=75&tn-needle=tcp-ao

Seems unrelated to select()+poll selftests changes, but rather to
timings in the kernel:
# # 1249[lib/proc.c:213]    Snmp6            Ip6OutNoRoutes: 0 => 1

It seems that the test relied on kernel adding a link-local route with
a loopback interface, but probably adding the interface got faster.
Seems like a trivial two-line fix by manually adding the link-local
route in userspace. Though, can't reproduce that flake locally on
thousands of runs.

Should I send the potential fix now for -net or wait until the merge
window closes and send for -net-next?

Thanks,
             Dmitry