linux-kernel - Re: [PATCH sched_ext/for-6.15-fixes] sched_ext: Remove a meaningless conditional goto in scx_select_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z-RhsP84IcMyLodA@gpd3>
Date: Wed, 26 Mar 2025 21:21:04 +0100
From: Andrea Righi <arighi@...dia.com>
To: Tejun Heo <tj@...nel.org>
Cc: David Vernet <void@...ifault.com>, Changwoo Min <changwoo@...lia.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH sched_ext/for-6.15-fixes] sched_ext: Remove a meaningless
 conditional goto in scx_select_cpu_dfl()

On Wed, Mar 26, 2025 at 10:12:11AM -1000, Tejun Heo wrote:
> scx_select_cpu_dfl() has a meaningless conditional goto at the end. Remove
> it. No functional changes.
> 
> Signed-off-by: Tejun Heo <tj@...nel.org>
> Cc: Andrea Righi <arighi@...dia.com>

Looks good, thanks!

Acked-by: Andrea Righi <arighi@...dia.com>

-Andrea

> ---
> Applied to sched_ext/for-6.15-fixes. Thanks.
> 
>  kernel/sched/ext_idle.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/sched/ext_idle.c b/kernel/sched/ext_idle.c
> index 45061b584380..b5f451e616d4 100644
> --- a/kernel/sched/ext_idle.c
> +++ b/kernel/sched/ext_idle.c
> @@ -584,8 +584,6 @@ s32 scx_select_cpu_dfl(struct task_struct *p, s32 prev_cpu, u64 wake_flags, u64
>  	 * increasing distance.
>  	 */
>  	cpu = scx_pick_idle_cpu(p->cpus_ptr, node, flags);
> -	if (cpu >= 0)
> -		goto out_unlock;
>  
>  out_unlock:
>  	rcu_read_unlock();
> -- 
> 2.48.1
>