[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20250326210735.696416-1-andrewjballance@gmail.com>
Date: Wed, 26 Mar 2025 16:07:35 -0500
From: Andrew Ballance <andrewjballance@...il.com>
To: remo@...nzli.dev
Cc: a.hindborg@...nel.org,
alex.gaynor@...il.com,
aliceryhl@...gle.com,
andriy.shevchenko@...ux.intel.com,
benno.lossin@...ton.me,
bjorn3_gh@...tonmail.com,
boqun.feng@...il.com,
dakr@...nel.org,
devicetree@...r.kernel.org,
dirk.behme@...bosch.com,
djrscally@...il.com,
gary@...yguo.net,
gregkh@...uxfoundation.org,
heikki.krogerus@...ux.intel.com,
linux-acpi@...r.kernel.org,
linux-kernel@...r.kernel.org,
ojeda@...nel.org,
rafael@...nel.org,
robh@...nel.org,
rust-for-linux@...r.kernel.org,
sakari.ailus@...ux.intel.com,
saravanak@...gle.com,
tmgross@...ch.edu,
andrewjballance@...il.com
Subject: Re: [PATCH 08/10] rust: property: Add property_get_reference_args
On Wed, Mar 26, 2025 at 12:13 PM Remo Senekowitsch Wrote:
> + pub fn property_get_reference_args(
> + &self,
> + prop: &CStr,
> + nargs: NArgs<'_>,
> + index: u32,
> + ) -> Result<(
> + ARef<Self>,
> + ArrayVec<{ bindings::NR_FWNODE_REFERENCE_ARGS as usize }, u64>,
> + )> {
> + let mut out_args = bindings::fwnode_reference_args::default();
> +
> + let (nargs_prop, nargs) = match nargs {
> + NArgs::Prop(nargs_prop) => (nargs_prop.as_char_ptr(), 0),
> + NArgs::N(nargs) => (ptr::null(), nargs),
> + };
> +
> + let ret = unsafe {
> + bindings::fwnode_property_get_reference_args(
> + self.0.get(),
> + prop.as_char_ptr(),
> + nargs_prop,
> + nargs,
> + index,
> + &mut out_args,
> + )
> + };
> + to_result(ret)?;
> +
> + let node = unsafe { FwNode::from_raw(out_args.fwnode) };
> + let mut args = ArrayVec::default();
> +
> + for i in 0..out_args.nargs {
> + args.push(out_args.args[i as usize]);
> + }
> +
> + Ok((node, args))
> + }
This function is missing safety comments.
Andrew
Powered by blists - more mailing lists